install icons to /usr/share and load them from there #4078
Conversation
rpcs3/Emu/RSX/overlay_controls.h
Outdated
| char result[ PATH_MAX ]; | ||
| ssize_t count = readlink( "/proc/self/rpcs3", result, PATH_MAX ); | ||
| auto executablePath = std::string( result, (count > 0) ? count : 0 ); | ||
| info = std::make_unique<image_info>((executablePath + "../share/Icons/ui/" + res).c_str()); |
There was a problem hiding this comment.
I don't see a dirname call… doesn't this result in something like /usr/local/bin/rpcs3../share/Icons/ui/something?
rpcs3/Emu/RSX/overlay_controls.h
Outdated
| if (info->data == nullptr) | ||
| { | ||
| char result[ PATH_MAX ]; | ||
| ssize_t count = readlink( "/proc/self/rpcs3", result, PATH_MAX ); |
There was a problem hiding this comment.
Is /proc/self/rpcs3 a thing? o_0 Just looked at /proc/self on an Arch VM, the only symlink there is exe.
So should be something like:
#ifdef __linux__
"/proc/self/exe"
#elif __FreeBSD__
"/proc/curproc/file"
#endifThere was a problem hiding this comment.
derp, thanks. Will the FreeBSD ifdef be the only BSD one I need?
There was a problem hiding this comment.
Not sure if any others are running RPCS3, but I guess you can make that just else.
hcorion
force-pushed
the
load-icons-from-usr-share
branch
2 times, most recently
from
a3cb92a
to
b2a9284
Compare
|
Folks, I found a little bug. When installing Atellier Escha & Logy, using the native interface, the instalation starts before finding a controller, breaking the installation giving an error in the dialog -3. If it's needed, I can provide logs of this! Let me know if it's necessary. |
|
Discuss on #4072 , not here |
|
Sorry @AniLeo , I'll paste this information there |
This also installs GuiConfigs but we don't load them from /usr/share yet.
This fixes Vulkan freezing at start on linux, and makes the icons show up in the new rsx overlay.
Font loading has yet to be fixed on arch-based distros.