Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #4079

Merged
merged 5 commits into from
Jan 19, 2018
Merged

Fixes #4079

merged 5 commits into from
Jan 19, 2018

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Jan 18, 2018 •
edited
Loading

  • emu: Add option to manage thread placement. Makes an impact on windows when using ryzen processors, most other cpus should be unaffected. Linux does a better job on its own so the option is not recommended on linux.
  • vulkan: Flush command queue on access violation event before attempting to touch texture cache in the event of access violations. This makes the device internal state consistent before texture operations. Fixes VK_ERROR_DEVICE_LOST in some cases when WCB is in use
  • Fixes for native overlay. Add fallback path in dev_flash for glyphs and fix vulkan freeze if icons are non-existent.
  • Fix Z clipping using selective z clamping.
  • Texture cache (blit engine) fix - Remove a conditional guess that has been properly REd

#4072
#4062

@kd-11 kd-11 force-pushed the rsx_volatile branch 4 times, most recently from ed6f0b2 to db76110 Compare January 18, 2018 19:52
kd-11 added 5 commits January 19, 2018 11:35
@kd-11
cell/scheduler: Manage thread placement depending on cpu hardware
2b68ec5
@kd-11
rsx: Synchronization improvements
4f4c041 
- Always flush the primary queue and wait if not involking readback from rsx thread
-- Should fix some instances of device_lost when using WCB
-- Marked remaining case as TODO
-- TODO: optimize amount of time rsx waits for external threads trying to read
@kd-11
overlay: Fixes
15995b0 
- Add fallback fonts including attempting to find glyphs in dev_flash
- Fix vulkan hang on startup if icons are not present
@kd-11
rsx/gl/vk: Simulate z clipping with selective depth clamp
a18a2ce 
- The scale offset matrix is fine but on real hardware the z results seem to be independent of near/far clipping distances
-- If depth falls within near/far, clamp depth value to [0,1]
@kd-11
rsx/texture_cache: Remove hacks; it has been proven that in offsets a…
512bd64 
…re in x16 fixed point
@kd-11 kd-11 merged commit 6828fbf into RPCS3:master Jan 19, 2018
@kd-11 kd-11 mentioned this pull request Jan 19, 2018
Closed
@cheasea23
Copy link

sir kd-11, i have issue - persona 5 fps drop - #4079.
but #4011 is fine bro.

@Zangetsu38
Copy link
Contributor

@cheasea23 you can test that https://ci.appveyor.com/project/kd-11/rpcs3/build/0.0.4-1296/artifacts ?

@cheasea23
Copy link

ok. i try bro. thanks reply. =D

@Asinin3
Copy link
Contributor

Asinin3 commented Jan 20, 2018

Also, you can just try disabling the thread scheduler in the CPU options tab.

@Asinin3 Asinin3 mentioned this pull request Feb 28, 2018
Closed
@waere00 waere00 mentioned this pull request Mar 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kd-11 @cheasea23 @Zangetsu38 @Asinin3