Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Half-fixes #4131

Merged
merged 14 commits into from Feb 8, 2018

Conversation

Projects
None yet
6 participants
@Nekotekina
Copy link
Member

Nekotekina commented Jan 30, 2018

No description provided.

@Drayano

This comment has been minimized.

Copy link

Drayano commented Jan 30, 2018

This PR broke Persona 5 title screen
rpcs3_2018-01-30_21-57-12

log file
RPCS3.log.gz

@Drayano

This comment has been minimized.

Copy link

Drayano commented Jan 30, 2018

@Zangetsu38 I already did that

@Lemiru

This comment has been minimized.

Copy link

Lemiru commented Jan 30, 2018

This PR fixes Zone of the enders HD collection not working with patch installed

Edit: Nevermind, I had outdated rpcs3

@Nekotekina

This comment has been minimized.

Copy link
Member Author

Nekotekina commented Jan 30, 2018

@Drayano @Lemiru Thanks for testing. Is it PPU or SPU that cause this bug? You can check by choosing interpreters in settings.

@AniLeo

This comment has been minimized.

Copy link
Contributor

AniLeo commented Jan 30, 2018

I can't reproduce that Persona 5 bug, works fine here with both Recompilers.
Edit: Can reproduce with Intel HD 530, not with NVIDIA 960M.

Regardless of PPU+SPU combination, graphical corruption seems to constantly happen on Intel (not on master though).

@Drayano

This comment has been minimized.

Copy link

Drayano commented Jan 31, 2018

I tried out every possible combination of PPU and SPU options and the problem doesn't seem to go away, i should precise that i'm on Intel UHD 630 igpu by the way.

EDIT : Ingame looks fine as far as i've tested, it's only the title screen that's messed up.

@isshininu

This comment has been minimized.

Copy link
Contributor

isshininu commented Jan 31, 2018

This PR cause a glitch during shaders compiling in Demon's Souls - everything is white with distant lights visible through the fog.
P.S. Nevermind, it was present simce an unknows PR. Doesn't affect anything.

@AniLeo

This comment has been minimized.

Copy link
Contributor

AniLeo commented Jan 31, 2018

Regarding the P5 bug, it's likely to be caused by #4127, it's happening on master

image

@Nekotekina Nekotekina force-pushed the Nekotekina:master branch from 12897fa to 432af6b Feb 2, 2018

url = https://github.com/llvm-mirror/llvm
branch = release_40
url = https://github.com/RPCS3/llvm
branch = release_60

This comment has been minimized.

Copy link
@Zangetsu38

Zangetsu38 Feb 2, 2018

Contributor

you leave that ?

This comment has been minimized.

Copy link
@AniLeo

AniLeo Feb 2, 2018

Contributor

It's required, look at the fork

This comment has been minimized.

Copy link
@Zangetsu38

Zangetsu38 Feb 2, 2018

Contributor

No required for moment, submdule is not updated with this URL, using actually llvm 4.0 same master, don't changed, so don't need change that, juste causing problem here

This comment has been minimized.

Copy link
@AniLeo

AniLeo Feb 2, 2018

Contributor

It shouldn't be building right now ¯_(ツ)_/¯but it will be required to use the fork

This comment has been minimized.

Copy link
@Zangetsu38

Zangetsu38 Feb 2, 2018

Contributor

you don't understund, for moment neko don't have updated submodule with this url, using old llvm4, so why changed that ? This just broken git for clone submodule.

Update this only after update LLVM Submodule, not before, just broken git.

This comment has been minimized.

Copy link
@Nekotekina

Nekotekina Feb 2, 2018

Author Member

What happens at clone submodule? I thought it still would be able to fetch the 4.0 commit.

This comment has been minimized.

Copy link
@Zangetsu38

Zangetsu38 Feb 2, 2018

Contributor

hmm after Verification Test with try update submodule is good.
Using "Git submodule sync" for update url with folder already exist, and "git submodule update --init" for update works.
So finaly no have problem, sorry for that.
I have just thinked set diferent url broken git cloe submodule but anyway, can get good commit, just strange set this now, and no after update llvm ^^

@Nekotekina Nekotekina force-pushed the Nekotekina:master branch from 432af6b to c339318 Feb 8, 2018

Nekotekina added some commits Jan 29, 2018

SPU: emit VZEROUPPER
Workaround dirty AVX high state
PPU LLVM: rewrite add/sub instructions
Use new patterns for saturation instructions
Avoid ZExt/SExt completely
SPU ASMJIT: minor change to ROTH instruction
Only AVX-512 path is changed (third version).
This instruction is extremely rare.
And the code is probably not optimal.
So this commit is pretty useless.
SPU ASMJIT: rewrite 128-bit shifts by bit
Six instructions changed to use xmm registers instead of gpr.
ROTQBII, ROTQMBII, SHLQBII look better (shifts by imm)
ROTQBI, ROTQMBI, SHLQBI changed for consistency (shifts by variable)

@Nekotekina Nekotekina force-pushed the Nekotekina:master branch from c339318 to 13aa88c Feb 8, 2018

@Nekotekina Nekotekina merged commit 13aa88c into RPCS3:master Feb 8, 2018

2 of 3 checks passed

continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.