Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt: Fix vfs dialog reset and saving and add some translations #4406

Merged
merged 3 commits into from Apr 15, 2018

Conversation

Projects
None yet
2 participants
@Megamouse
Copy link
Contributor

commented Apr 7, 2018

Reset would crash the app, because a cleared item received a signal on currentItemChanged.
Also, Reset did not reset the list as one might think, but clean it and then result in wrong behaviour.
Furthermore the settings were saved, regardless of accepting the dialog or not.

fixes #4444

@AniLeo AniLeo added GUI Bugfix labels Apr 8, 2018

Megamouse added some commits Apr 7, 2018

Qt: Fix vfs dialog reset and add some translations
Reset would crash the app, because a cleared item received a signal on currentItemChanged.
Also, Reset did not reset the list as one might think, but clean it and then result in wrong behaviour.
Furthermore the settings were saved, regardless of accepting the dialog or not.

@Megamouse Megamouse force-pushed the Megamouse:vfs_fix branch from 81063b7 to 0d4fd34 Apr 13, 2018

@AniLeo AniLeo merged commit 41f4bb9 into RPCS3:master Apr 15, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Megamouse Megamouse deleted the Megamouse:vfs_fix branch Apr 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.