Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPU ASMJIT v2.0 #4422

Merged
merged 11 commits into from
Apr 21, 2018
Merged

SPU ASMJIT v2.0 #4422

merged 11 commits into from
Apr 21, 2018

Conversation

Nekotekina
Copy link
Member

No description provided.

@woj1993
Copy link

woj1993 commented Apr 9, 2018

Is it ready for tests?

@dbz400
Copy link
Contributor

dbz400 commented Apr 9, 2018

fix #3678

@MsDarkLow
Copy link
Contributor

Yakuza 3

After I finish a cutscene, the game simply gives a blackscreen with a frozen fps.
Nothing new is output in the log.

Master: RPCS3Yakuza3Master.log.gz

PR: RPCS3Yakuza3SPUPR.log.gz

@Yahfz
Copy link
Contributor

Yahfz commented Apr 9, 2018

Most games i've tried so far either hang (with audio) or they keep loading forever without any errors to display on the log.

@SakataGintokiYT
Copy link
Contributor

SakataGintokiYT commented Apr 9, 2018

Naruto: Ultimate Ninja Storm 30FPS to 4FPS
(Click to Expand)

Naruto:Storm 1

1

RPCS3.log.gz

OutRun Online Arcade
Freezes up during loading the shader cache.
RPCS3.log.gz

@Xcedf
Copy link

Xcedf commented Apr 9, 2018

Many games have major speed regression now, other can hang randomly now

@PutyingZ
Copy link

PutyingZ commented Apr 9, 2018

Test it on Sengoku Basara 4 Sumeragi , Up to 8 frames , but the sound is broken in the battle , and down a dozen frames in the game menu .

@micaelis72
Copy link

Videos on Valkyria Chronicles no longer hangs, but instead the process doesn't keep going after the video is played. If further info is necessary, please just tell me that I'll append the logs

@ghost
Copy link

ghost commented Apr 9, 2018

esboco 23

@ghost
Copy link

ghost commented Apr 9, 2018

RPCS3.log.gz

@AniLeo
Copy link
Member

AniLeo commented Apr 9, 2018

WipEout HD

F {SPU[0x2000004] Thread (WOHD_multiSPU_CellSpursKernel4) [0x03148]} class std::runtime_error thrown: Unknown command (cmd=0x98, lsa=0x42b51b33, ea=0x3e98, tag=0x20, size=0xf436)
(in file Emu\Cell\SPUThread.cpp:1404)
F {SPU[0x2000001] Thread (WOHD_multiSPU_CellSpursKernel1) [0x03148]} class std::runtime_error thrown: Unknown command (cmd=0xef, lsa=0x3f16426a, ea=0x3e98, tag=0x0, size=0xbe54)
(in file Emu\Cell\SPUThread.cpp:1404)
F {SPU[0x2000002] Thread (WOHD_multiSPU_CellSpursKernel2) [0x03148]} class std::runtime_error thrown: Unknown command (cmd=0xf, lsa=0x3f1d617f, ea=0x3e98, tag=0x0, size=0x25b4)
(in file Emu\Cell\SPUThread.cpp:1404)
F {SPU[0x2000003] Thread (WOHD_multiSPU_CellSpursKernel3) [0x03148]} class std::runtime_error thrown: Unknown command (cmd=0x1b, lsa=0x3f1cf864, ea=0x3e98, tag=0x0, size=0x9111)
(in file Emu\Cell\SPUThread.cpp:1404)
F {SPU[0x2000000] Thread (WOHD_multiSPU_CellSpursKernel0) [0x03148]} class std::runtime_error thrown: Unknown command (cmd=0x84, lsa=0x3f1603da, ea=0x3e98, tag=0x0, size=0xff32)
(in file Emu\Cell\SPUThread.cpp:1404)

@kamer1337
Copy link

seems like finally fixed access violation 0x0 on loading screen in Tony Hawk's Proving Ground with SPU ASMJIT

@legend800
Copy link

GTI Club [NPUB30044] hangs on load. 5/5 times. Switch to today's daily and it loads fine.
RPCS3.log.gz

@Xcedf
Copy link

Xcedf commented Apr 10, 2018

Btw, combined this branch with Overlay_stuff, mgs4 no longer crashes on ASMjit

@fifazalata
Copy link

fifazalata commented Apr 10, 2018

Good news.
This fixes the stuttery audio in anime cutscenes on Persona 5.

@MSuih
Copy link
Member

MSuih commented Apr 10, 2018

Skate 2 now gets stuck in black screen on boot, with nothing interesting in the log. God of War Collection: Volume 2 suffers from the same issue when trying to go ingame in either of the titles.

Burnout: Paradise triggers fatal error during intro.

Unhandled Win32 exception 0x80000003.
Exception address: 000000008f8012ff.
ExceptionInformation[0x0]: 0000000000000000.
Instruction address: 000000008f8012ff.
RPCS3 image base: 0000000000010000.

RPCS3.log.gz

Uncharted 1 no longer goes ingame, it either throws a random error or just gets stuck in black screen
Unimplemented instruction
Unknown command

@Nekotekina
Copy link
Member Author

Pushed optimized verification for AVX-512. AVX version will be implemented later.

@Nekotekina
Copy link
Member Author

Maybe SSE2 too but it doesn't matter that much.

@JohnHolmesII
Copy link
Contributor

Will the AVX include AVX2?

@stride21
Copy link

Killzone 3 no longer intros
RPCS3.log.gz

Shadow of the Colossus:
Unhandled Win32 exception 0xC0000005.
Segfault reading location 00000000859b4aef at 00000000819746f0.
Instruction address: 00000000819746f0.
RPCS3 image base: 0000000000010000.

inFAMOUS 2
Unhandled Win32 exception 0xC0000005.
Segfault reading location 0000000089291eef at 0000000085251af0.
Instruction address: 0000000085251af0.
RPCS3 image base: 0000000000010000.

both games get error message just before loading to the main menu.

@JohnGodgames
Copy link

Hmm not good https://ci.appveyor.com/project/rpcs3/rpcs3/build/0.0.5-9f3f8dec

Red Dead redemption

Unhandled Win32 exception 0xC0000005.
Segfault reading location 00000000c4d64bef at 00000000c0d247f0.
Instruction address: 00000000c0d247f0.
RPCS3 image base: 0000000000010000.

rdr RPCS3.log.gz

@Kojikun1
Copy link

Kojikun1 commented Apr 11, 2018

With AVX processor now all the games that I tested crash after loading pipelines.
crash pic

@greentop
Copy link

471685a is segfaulting on Ubuntu 16.04 as well when attempting to launch any games. (i7 3770)

Thread 5 "PPU[0x1000000] " received signal SIGSEGV, Segmentation fault.
0x0000000040216ab2 in __0x7530c ()
(gdb) bt
#0  0x0000000040216ab2 in __0x7530c ()
#1  0x0000000000a16119 in ppu_thread::exec_task() ()
#2  0x0000000000a167c1 in ppu_thread::fast_call(unsigned int, unsigned int) ()
#3  0x0000000000a1ca09 in ppu_thread::cpu_task() ()
#4  0x000000000084c556 in cpu_thread::on_task() ()
#5  0x0000000000dbb311 in task_stack::task_type<named_thread::start_thread(std::shared_ptr<void> const&)::{lambda()#1}>::invoke() ()
#6  0x0000000000dbe33c in thread_ctrl::start(std::shared_ptr<thread_ctrl> const&, task_stack)::{lambda(void*)#1}::_FUN(void*) ()
#7  0x00007ffff6e536ba in start_thread (arg=0x7fffc7cde700) at pthread_create.c:333
#8  0x00007ffff0a6441d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109

@Dokman
Copy link

Dokman commented Apr 11, 2018

FMV in Infamous had a slowdown on Ryzen 1800x
image

Then i have a crash
image

@resadent
Copy link

resadent commented Apr 11, 2018

Also error here with BLES01756
image
And can't boot any games, all with same error.

@Nekotekina Nekotekina merged commit bd1d4de into RPCS3:master Apr 21, 2018
@Nekotekina Nekotekina changed the title [WIP] SPU ASMJIT update SPU ASMJIT v2.0 Apr 21, 2018
@RainKikyou
Copy link

@raven02 In the latest build, the speed is slower than before(some build of this pr, the speed did improve).may have to wait until spu llvm is turned on before it really improves
qq 20180422105408

@jobs-git
Copy link

Title: D3

Sound stuttering has been reduced
Stuttering on intro has been eliminated at SPU = 2

But there is a new fatal on SPUASMJIT Vulkan

F {SPU[0x2000003] Thread (CellSpursKernel3) [0x059a8]} class std::runtime_error thrown: Unknown/Illegal instruction (0x02006295)
(in file Emu\Cell\SPUASMJITRecompiler.cpp:1225)

@ActualMandM
Copy link

There's an issue on regressions that came from this PR. #4473

@Parthorisian
Copy link

Parthorisian commented Apr 23, 2018

[BLUS30335]splatterhouse gained almost 70-100%full speed performance improvement(reachable after first checkpoint, when you can switch PPU interpreter to recompiler)

@frymezim
Copy link

There's a 5-10FPS improvement on my 4th Gen 4770HQ on Ni no Kuni.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.