Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bugfix #4424

Merged
merged 1 commit into from Apr 10, 2018
Merged

Minor bugfix #4424

merged 1 commit into from Apr 10, 2018

Conversation

@JohnHolmesII
Copy link
Contributor

@JohnHolmesII JohnHolmesII commented Apr 9, 2018

Fixes issue #4420

It looks like some games may provide an icon resource, but they don't always provide a save title for creating a new save. Odd behavior, but it is what it is. on Uncharted, it looks like the data gets overwritten afterwards by the game, cause if I load a newly created save made with this pr it has all the names and metadata.

I'm open to suggestions as to the correctness of my implementation.

kd-11
kd-11 approved these changes Apr 10, 2018
@kd-11 kd-11 merged commit 7303f04 into RPCS3:master Apr 10, 2018
2 checks passed
@NPJB00512
Copy link

@NPJB00512 NPJB00512 commented Apr 10, 2018

Gundam EXVSFB can play to FPS 25
RPCS3.log.gz

@kroaton kroaton mentioned this pull request Apr 15, 2018
@JohnHolmesII JohnHolmesII deleted the uncharted-save-fix branch Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants