Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some lv2 syscall names #4490

Merged
merged 6 commits into from May 6, 2018

Conversation

Projects
None yet
4 participants
@Maxetto
Copy link
Contributor

Maxetto commented Apr 26, 2018

Based on new changes on: http://www.psdevwiki.com/ps3/LV2_Functions_and_Syscalls#LV2_Syscalls

I'm really sorry I can't help more the project, hope it can be helpful for the future.

@Nekotekina Nekotekina self-requested a review Apr 26, 2018

@Maxetto

This comment has been minimized.

Copy link
Contributor Author

Maxetto commented Apr 27, 2018

I found this pastebin which is somewhat accurate, but I've no idea how to check whether those syscall names are right or wrong:
https://pastebin.com/aTRaFstS

EDIT: Some are also mentioned here: https://github.com/zecoxao/ps3ida/blob/master/syscall_names.idh

@@ -187,6 +187,7 @@ extern std::string ppu_get_syscall_name(u64 code)
case 250: return "sys_spu_thread_group_set_cooperative_victims";
case 251: return "sys_spu_thread_group_connect_event_all_threads";
case 252: return "sys_spu_thread_group_disconnect_event_all_threads";
case 253: return "sys_spu_thread_group...";

This comment has been minimized.

@elad335

elad335 Apr 28, 2018

Contributor

dont put incomplete names here, since whenever a game use this unimplemented syscall it will get logged as "sys_spu_thread_group..." instead of "syscall_253". you can see whats problematic with that.

This comment has been minimized.

@Maxetto

Maxetto Apr 28, 2018

Author Contributor

I saw some incomplete names already inside so I tought it would've been ok to add this.
Should I also remove already existing incomplete names?

This comment has been minimized.

@elad335

elad335 Apr 28, 2018

Contributor

yup 👌

@@ -347,7 +347,7 @@ extern std::string ppu_get_syscall_name(u64 code)
case 573: return "sys_pad_dbg_ldd_set_data_insert_mode";
case 574: return "sys_pad_ldd_register_controller";
case 575: return "sys_pad_ldd_get_port_no";
case 577: return "sys_pad_manager_...";
case 579: return "sys_bluetooth_aud_serial_unk1";

This comment has been minimized.

@AniLeo

AniLeo Apr 29, 2018

Contributor

Are you sure the syscall has "unk1" in the name? Seems very unlikely

This comment has been minimized.

@Maxetto

Maxetto Apr 29, 2018

Author Contributor

Actually you are right. Fixed.

Maxetto added some commits Apr 29, 2018

@AniLeo

AniLeo approved these changes Apr 29, 2018

@elad335
Copy link
Contributor

elad335 left a comment

LGTM

@Nekotekina Nekotekina merged commit dca6f1f into RPCS3:master May 6, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.