Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix section reuse #5013
2 times, most recently
Aug 20, 2018
I'm curious if this actually fixes more games than P5!
Mistakes happen, don't worry. Thanks for all your help throughout this debugging effort - I'm starting to think it's a waste that most of our conversation happened in DMs, lots of useful knowledge there.
Once this gets merged I'll see about pushing some of the sanity checks/assertions I wrote to debug this, so we can avoid more texture cache issues in the future.
I try Nexus and Boletaria 1-1, ask me if you need more information and tests .
others setting are on default value .
I try to do more levels
with disable async shaders (on already visited level so no caching shaders) looks like the same with enable; but I notice this thing (enable/disable async is the same):
Hope that can help you
referenced this pull request
Aug 21, 2018
Non TSX CPU. Shaders cache has been cleared. No any flickering noticed+large performance boost(ASMJIT Recompiler) similar to pr4935.
Been using #5013 and it still freezes but it will unfreeze if I give it some time. It has done this twice. I still get the flicker once in a while too. In both cases the RPCS3 main window is not accessible. It isn't usable cause once this happens it freezes again in seconds.
I have tested this commit (or to be exact ruipin@4e44fbd which has a bug fix applied and a ton of debug checks and assertions) on both P5 and DeS for about 1 hour each, and could not reproduce any issues (other than the random black flickering in DeS which predates this PR and is probably a separate issue). I want to test it in Uncharted or something but sadly won't have much time to do so for the rest of the week.
Just make sure to fix the bug I reported in one of the review comments and I think this commit is ready to be merged.
Two small comments, but everything looks good to me. I'll try to find time later today to test this and let you know. Though I think it could be merged without any issues at this point.