Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsx: Fix fog behaviour #5086

Merged
merged 2 commits into from Sep 6, 2018

Conversation

Projects
None yet
5 participants
@kd-11
Copy link
Contributor

kd-11 commented Sep 5, 2018

  • This is likely incorrect but hw tests are still inconclusive so this is the best bet right now.

Possible fix for #5066

@kd-11 kd-11 changed the title [Testers Needed] rsx: Fix fog behaviour [Testers Needed][WIP] rsx: Fix fog behaviour Sep 5, 2018

@namkazt

This comment has been minimized.

Copy link

namkazt commented Sep 5, 2018

Diablo 3 :ROS working again!

Great work
dwad3212

@Rpcs3tester

This comment has been minimized.

Copy link

Rpcs3tester commented Sep 5, 2018

@kd-11 thanks it's fixed

1
2
3

@Emulator-Team-2

This comment has been minimized.

Copy link

Emulator-Team-2 commented Sep 5, 2018

Fixed regression in:
-After Burner Climax
-Dragon Ball: Xenoverse

@i2puni

This comment has been minimized.

Copy link

i2puni commented Sep 5, 2018

I'm sorry.
I am not good at English.

But I want to give you some feedback

The black texture problem of the "Catherine" game screen has been fixed in this version.

Previous version
cap2

This version
cap

Thank you.

@kd-11 kd-11 force-pushed the kd-11:rsx_volatile branch from 8b15f21 to fd3f660 Sep 5, 2018

@kd-11 kd-11 changed the title [Testers Needed][WIP] rsx: Fix fog behaviour rsx: Fix fog behaviour Sep 5, 2018

@kd-11 kd-11 added RSX Bugfix labels Sep 5, 2018

rsx: Preserve fog coordinate across shader stages
- The x value contains the VP output value interpolated across primitive surface
- The y coordinate contains the fog fraction according to the selected fog formula

@kd-11 kd-11 force-pushed the kd-11:rsx_volatile branch from b68a2ab to 7d53cee Sep 6, 2018

@kd-11 kd-11 force-pushed the kd-11:rsx_volatile branch from 7d53cee to 7715e3d Sep 6, 2018

@kd-11 kd-11 merged commit 66610a2 into RPCS3:master Sep 6, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kd-11 kd-11 referenced this pull request Sep 6, 2018

Closed

Regressions after #5038 #5066

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.