Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsx: Minor texture cache fixes #5099

Merged
merged 1 commit into from Sep 10, 2018

Conversation

Projects
None yet
5 participants
@kd-11
Copy link
Contributor

kd-11 commented Sep 8, 2018

  • Retag resources reprotected under flush_always rules.
  • Properly check for blit resource fitting taking into account format
    mismatch.

Fixes some problems encountered by @ruipin during validation of the texture cache routines.

@kd-11 kd-11 changed the title rsx: Minor texture cache fixes [WIP] rsx: Minor texture cache fixes Sep 8, 2018

@kd-11

This comment has been minimized.

Copy link
Contributor Author

kd-11 commented Sep 8, 2018

Problems with false rejection, relegating to WIP for now.

@M220

This comment has been minimized.

Copy link

M220 commented Sep 8, 2018

This PR Caused Flashing in The last of Us with renderer set to vulkan :
untitled
And With Renderer set to OpenGL, 3D textures will not get rendered ( 2D Textures like texts are fine ) :
2

@elhaya

This comment has been minimized.

Copy link

elhaya commented Sep 8, 2018

Kratos has no face with this PR!
image

@kd-11 kd-11 force-pushed the kd-11:rsx_volatile branch from d3ebeca to 41a87c4 Sep 9, 2018

@kd-11

This comment has been minimized.

Copy link
Contributor Author

kd-11 commented Sep 9, 2018

Retest, should be fixed now.

@Zangetsu38

This comment has been minimized.

Copy link
Contributor

Zangetsu38 commented Sep 9, 2018

Amy is fixed

@kd-11 kd-11 changed the title [WIP] rsx: Minor texture cache fixes rsx: Minor texture cache fixes Sep 9, 2018

@elhaya

This comment has been minimized.

Copy link

elhaya commented Sep 9, 2018

confirmed, with the last commit gow 3 is now fixed:
image
thank you kd-11!!!

@kd-11 kd-11 force-pushed the kd-11:rsx_volatile branch from 41a87c4 to 8f71a28 Sep 10, 2018

@kd-11 kd-11 referenced this pull request Sep 10, 2018

Closed

#4162 Regressions #4247

rsx: Minor texture cache fixes
- Retag resources reprotected under flush_always rules
- Properly check for blit resource fitting taking into account format
mismatch, pitch mismatch and typeless transfers
@kd-11

This comment has been minimized.

Copy link
Contributor Author

kd-11 commented Sep 10, 2018

@kd-11 kd-11 referenced this pull request Sep 10, 2018

Closed

Regressions from #4611 #4651

@kd-11 kd-11 force-pushed the kd-11:rsx_volatile branch from 8f71a28 to 70a8474 Sep 10, 2018

@kd-11 kd-11 merged commit f413996 into RPCS3:master Sep 10, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Atrosincity

This comment has been minimized.

Copy link

Atrosincity commented Sep 10, 2018

Can now access training menu in soul calibur V.
base profile screenshot 2018 09 10 - 14 45 00 85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.