New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsx: Temporarily disable readback predictions if failure rate exceeds 50% #5163

Merged
merged 2 commits into from Sep 24, 2018

Conversation

Projects
None yet
2 participants
@kd-11
Contributor

kd-11 commented Sep 22, 2018

  • This happens often in loading screens where the memory usage pattern is often randomized by loading in of assets.

Fixes #5105
Fixes #4924

rsx: Disable predictions if 50% of predictions are wrong
- This happens often in loading screens where the memory usage pattern is often randomized by loading in of assets
@kd-11

This comment has been minimized.

Contributor

kd-11 commented Sep 22, 2018

As this set interacts with the texture cache, this PR will be rebased/rewritten and merged after #5115 has been merged.

@kd-11 kd-11 changed the title from [No Merge] rsx: Temporarily disable readback predictions if failure rate exceeds 50% to [WIP] rsx: Temporarily disable readback predictions if failure rate exceeds 50% Sep 24, 2018

@kd-11 kd-11 changed the title from [WIP] rsx: Temporarily disable readback predictions if failure rate exceeds 50% to rsx: Temporarily disable readback predictions if failure rate exceeds 50% Sep 24, 2018

@kd-11 kd-11 merged commit dab30c0 into RPCS3:master Sep 24, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hockland

This comment has been minimized.

hockland commented Sep 25, 2018

Just confirming that this does indeed fix #5105. Tested Ni No Kuni out after downloading this PR and have not had a freeze since. Instead the game now just slows down to a crawl on the odd occasion, which I'd far prefer to freezes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment