New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cellGame: Add missing nullptr checks #5261

Merged
merged 2 commits into from Nov 2, 2018

Conversation

Projects
None yet
4 participants
@elad335
Contributor

elad335 commented Oct 17, 2018

if the param is null pointer, the library simply skips writing into it.

@AniLeo AniLeo added HLE Bugfix labels Oct 17, 2018

cellGame: Add missing nullptr checks
if the param is null pointer, the library simply skips writing into it. also fix the order of writes.
@@ -641,15 +641,16 @@ error_code cellGameCreateGameData(vm::ptr<CellGameSetInitParams> init, vm::ptr<c
return CELL_GAME_ERROR_ACCESS_ERROR; // ???
}
// cellGameContentPermit should then move files in non-temporary location and return their non-temporary displacement
if (tmp_contentInfoPath) strcpy_trunc(*tmp_contentInfoPath, tmp_contentInfo);

This comment has been minimized.

@kd-11

kd-11 Oct 27, 2018

Contributor

The implied order of events here is backed up by a testcase?

This comment has been minimized.

@elad335

elad335 Oct 27, 2018

Contributor

the pr is based on the disassembly of libsysutil_game, I dont have a testcase for any of this.

@Nekotekina Nekotekina merged commit 43b75cc into RPCS3:master Nov 2, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@elad335 elad335 deleted the elad335:cellgame-nullptr branch Nov 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment