Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static HLE implementation #5285

Merged
merged 2 commits into from Feb 27, 2019

Conversation

Projects
None yet
4 participants
@RipleyTom
Copy link
Contributor

RipleyTom commented Oct 26, 2018

This is a basic implementation of static function hooking.
The functions implemented are:
-memcpy
-memset
-memmove
-memcmp
and the wchar_t variants of those functions(wmemcpy, etc).

To be active the hook static functions has to be checked in debug tab.

I've not noticed any performance gain from it on the few games I've tested it on but since it's done, here it is.

@RipleyTom RipleyTom force-pushed the RipleyTom:StaticHLE_Clean branch from 800fa49 to 4ce1bfd Oct 26, 2018

Show resolved Hide resolved rpcs3/Emu/Cell/PPUModule.cpp Outdated
@kd-11
Copy link
Contributor

kd-11 left a comment

Comment consistency is lacking - some start with upper case, some with lower case, some have space after the marker, others don't. Also, CamelCase vs snake_case inconsistencies with method naming.

@RipleyTom RipleyTom force-pushed the RipleyTom:StaticHLE_Clean branch from 4ce1bfd to f4dfefb Oct 27, 2018

@RipleyTom

This comment has been minimized.

Copy link
Contributor Author

RipleyTom commented Oct 27, 2018

Cleaned up the comments and the code.
Added an option to specify module of hle and redirected memcpy to sys_libc.

@RipleyTom RipleyTom force-pushed the RipleyTom:StaticHLE_Clean branch 4 times, most recently from 222cafd to d4c5c65 Nov 8, 2018

@kd-11 kd-11 requested a review from Nekotekina Jan 2, 2019

@kd-11

This comment has been minimized.

Copy link
Contributor

kd-11 commented Jan 2, 2019

Looks to be somewhat more complete; just needs a review from neko.

@RipleyTom RipleyTom force-pushed the RipleyTom:StaticHLE_Clean branch from d4c5c65 to 05e75d3 Jan 11, 2019

@kd-11

kd-11 approved these changes Jan 15, 2019

Copy link
Contributor

kd-11 left a comment

+1 for unifying code style :p

@Nekotekina

This comment has been minimized.

Copy link
Member

Nekotekina commented Jan 15, 2019

You cannot use native wchar functions.

@RipleyTom RipleyTom force-pushed the RipleyTom:StaticHLE_Clean branch 2 times, most recently from 1efe6df to a44e7fb Feb 11, 2019

@RipleyTom

This comment has been minimized.

Copy link
Contributor Author

RipleyTom commented Feb 11, 2019

I removed the wchar functions.

@RipleyTom RipleyTom force-pushed the RipleyTom:StaticHLE_Clean branch from a44e7fb to 0ac0531 Feb 19, 2019

@Nekotekina Nekotekina merged commit de5379a into RPCS3:master Feb 27, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.