Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microphone emulation #5446

Merged
merged 1 commit into from Jul 11, 2019

Conversation

@RipleyTom
Copy link
Contributor

commented Dec 21, 2018

Supports 4 microphone types:
-Standard: your basic microphone
-Singstar: fakes a singstar microphone device
-Real Singstar: if you want to use your real singstar microphones
-Rocksmith: to use with rocksmith games and your rocksmith dongle( thanks @jjsat )

Configuration is under the Audio tab.

@RipleyTom RipleyTom force-pushed the RipleyTom:daMic branch from ea93bc4 to cb4ae58 Dec 21, 2018
@Zangetsu38

This comment has been minimized.

Copy link
Contributor

commented Dec 22, 2018

little forget tooltip jso, i have add

"microphoneBox": "Select your mic device ps3.",

@RipleyTom RipleyTom force-pushed the RipleyTom:daMic branch from cb4ae58 to 6d52a6a Dec 22, 2018
@RipleyTom

This comment has been minimized.

Copy link
Contributor Author

commented Dec 22, 2018

Good catch, added a tooltip.

@LuismaSP89

This comment has been minimized.

Copy link

commented Dec 27, 2018

Great job :P another ps3 accesory emulated. If you want to try next with Buzz controllers you have my blessing xD

@RipleyTom RipleyTom force-pushed the RipleyTom:daMic branch from 6d52a6a to ef7bf18 Dec 31, 2018
@RipleyTom RipleyTom changed the title Singstar microphone emulation [WIP] Singstar microphone emulation Jan 1, 2019
@RipleyTom RipleyTom changed the title [WIP] Singstar microphone emulation [WIP] microphone emulation Jan 1, 2019
@RipleyTom RipleyTom changed the title [WIP] microphone emulation [WIP] Microphone emulation Jan 1, 2019
@RipleyTom RipleyTom force-pushed the RipleyTom:daMic branch 2 times, most recently from 723b94a to c1c438a Jan 1, 2019
@RipleyTom RipleyTom force-pushed the RipleyTom:daMic branch 3 times, most recently from 0c43938 to 2a663d4 Jan 1, 2019
@RipleyTom RipleyTom force-pushed the RipleyTom:daMic branch from 2a663d4 to 6a6a5f5 Jan 2, 2019
@RipleyTom RipleyTom force-pushed the RipleyTom:daMic branch 3 times, most recently from edcf974 to 844fd12 Jan 11, 2019
@RipleyTom RipleyTom force-pushed the RipleyTom:daMic branch 2 times, most recently from f930a25 to 5062286 Jan 12, 2019
@psennermann

This comment has been minimized.

Copy link

commented Jan 12, 2019

"Singstar vol.1" works really good with any microphone, while "Singstar Vasco" doesn't work (although I have an original Singstar USB converter attached to the usb port, that game keeps on asking to attach one…)

The only minor problems I encountered on my PC with "Singstar vol. 1" are:

  • FMV video is out of sync compared to audio (but fortunately text words are perfectly in sync)

  • using 2 Singstar microphones with the usb converter they're recognised as one (like what happens in the Windows 10 audio manager); so if you wanna play duett you have to attach another usb microphone...

  • when you want to rehear the singed song, the music is all messed up (maybe #5456 could help in this case?)

@RipleyTom RipleyTom force-pushed the RipleyTom:daMic branch from 5062286 to 121d170 Jan 14, 2019
@RipleyTom

This comment has been minimized.

Copy link
Contributor Author

commented Jan 14, 2019

I added support(untested) for real Singstar devices.
Also added UI so you can select the microphones you want to use specifically.
As for Singstar Vasco I didn't have time to investigate why it doesn't recognize the device yet.

@RipleyTom RipleyTom force-pushed the RipleyTom:daMic branch 2 times, most recently from 6a1d7a9 to 86d16ab Jan 14, 2019
@psennermann

This comment has been minimized.

Copy link

commented Jan 14, 2019

Using "Real Singstar" option, microphone doesn't work well (it has a "muffled/garbled" sound somewhat like what you hear when you want to rehear the singed song), while using two microphones attached to the Singstar usb converter, every microphone outputs voice for both blue and red microphone (like you were singing with both at the same time)

@RipleyTom RipleyTom force-pushed the RipleyTom:daMic branch from 86d16ab to aa015b4 Jan 15, 2019
@RipleyTom RipleyTom force-pushed the RipleyTom:daMic branch from b33b922 to c0fd29f May 9, 2019
@RipleyTom RipleyTom changed the title [WIP] Microphone emulation Microphone emulation May 9, 2019
@RipleyTom

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

Did a bit of spring cleaning, tested on linux, added rocksmith support as suggested by @jjsat .
Biggest surprise is that it seems to now work perfectly with Karaoke Revolution which I couldn't figure the issues with. Apparently the issues were not with my cellMic implementation so I'm removing the [WIP].

@RipleyTom RipleyTom force-pushed the RipleyTom:daMic branch 2 times, most recently from f157681 to 69f0d06 May 9, 2019
@psennermann

This comment has been minimized.

Copy link

commented May 11, 2019

No problems to report

@Megamouse Megamouse added the Audio label May 15, 2019
@LonelyDragon123

This comment has been minimized.

Copy link

commented May 18, 2019

I have problem in Guitar Hero. Even with original Logitech guitar hero mic I have loud noise, and if I say something it changes a little, which means mic working, but sound input very distorted.

Copy link
Contributor

left a comment

Some nits

rpcs3/Emu/Cell/Modules/cellAvconfExt.cpp Show resolved Hide resolved
rpcs3/Emu/Cell/Modules/cellMic.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/Cell/Modules/cellMic.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/Cell/Modules/cellMic.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/Cell/Modules/cellMic.cpp Outdated Show resolved Hide resolved
rpcs3/rpcs3qt/settings_dialog.cpp Show resolved Hide resolved
rpcs3/Emu/Cell/Modules/cellMic.cpp Outdated Show resolved Hide resolved
rpcs3/Emu/Cell/Modules/cellMic.cpp Show resolved Hide resolved
@RipleyTom RipleyTom force-pushed the RipleyTom:daMic branch 2 times, most recently from 115f2b7 to f5004c5 May 30, 2019
@RipleyTom

This comment has been minimized.

Copy link
Contributor Author

commented May 31, 2019

@LonelyDragon123 make sure you're using standard microphone(in the microphone type combobox in audio tab) with guitar hero. I just tested guitar hero 5 and it worked perfectly.

@Megamouse Megamouse added the GUI label May 31, 2019
@RipleyTom RipleyTom changed the title Microphone emulation [Rework In Progress] Microphone emulation Jun 20, 2019
@RipleyTom RipleyTom force-pushed the RipleyTom:daMic branch 2 times, most recently from 6e55fb7 to 6f6bfd1 Jun 20, 2019
@RipleyTom RipleyTom force-pushed the RipleyTom:daMic branch 2 times, most recently from 8240e59 to 448b776 Jun 20, 2019
@RipleyTom RipleyTom changed the title [Rework In Progress] Microphone emulation Microphone emulation Jun 20, 2019
@RipleyTom RipleyTom force-pushed the RipleyTom:daMic branch from 448b776 to 86c1557 Jun 20, 2019
@RipleyTom RipleyTom force-pushed the RipleyTom:daMic branch from 86c1557 to 83b328d Jul 1, 2019
rpcs3/Emu/Cell/Modules/cellMic.cpp Show resolved Hide resolved
rpcs3/Emu/Cell/Modules/cellMic.cpp Show resolved Hide resolved
rpcs3/Emu/Cell/Modules/cellMic.cpp Outdated Show resolved Hide resolved
@RipleyTom RipleyTom force-pushed the RipleyTom:daMic branch from 83b328d to 0812c56 Jul 4, 2019
@RipleyTom RipleyTom force-pushed the RipleyTom:daMic branch from 0812c56 to 36ef13b Jul 5, 2019
@AniLeo AniLeo merged commit 6c6b973 into RPCS3:master Jul 11, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@RipleyTom RipleyTom deleted the RipleyTom:daMic branch Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.