Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsx: Fixups and improvements #5565

Merged
merged 13 commits into from Jan 25, 2019

Conversation

Projects
None yet
@kd-11
Copy link
Contributor

commented Jan 16, 2019

  • Rewrite index buffer base offsets. Preserves use of u16 index buffers for consistency and reduced memory footprint.
  • Partial revert of a change in fbo_fixes PR affecting async shaders.
  • Fix Red-Blue color inversion when using OpenGL (old regression)
  • Avoid potential deadlock in fifoctrl
  • Reimplement alpha-to-coverage transparency with a better approximation technique
  • Rewrite vertex attribute divisor logic
  • Misc spec compliance and typo fixes
@uaqlover

This comment has been minimized.

Copy link

commented Jan 16, 2019

where i can download the branch

@digitaldude555

This comment has been minimized.

Copy link

commented Jan 16, 2019

Click green checkmark and click details.

@stride21

This comment has been minimized.

Copy link

commented Jan 16, 2019

Can confirm that The Last of Us, Battlefield: Bad Company and Uncharted 3 no longer have issues with Async Shader Compiler.

Before:
prev journey
After:
journey pr

@legend800

This comment has been minimized.

Copy link

commented Jan 17, 2019

Tested a bunch of games and didn't see any improvements or regressions.

This regression from FBO fixes PR is still active:
#4949

Tested all of these titles (disregard the general emu notes - not related to PR - but maybe of some interest):
• *(d)Time Crisis 4 Settings: WCB | Note: Input lag sometimes (broken)
• *(d)Deadstorm Pirates(+install data) Settings: WCB | Note: Minor transparent textures (logged)
• Backbreaker Vengeance(v1.0-c00)[WCB(field cache), Blit(fixes textures on VK)] 22 fps on 5-2 (need 25 min) | Settings: Scaling 100%, SPU=2 | Note: Missing crowd (Vk broken-logged, SPU LLVM broken-logged)
• (d)Captain America(3D)[Stretch, Strict (Cap shading)] – Slow(~20 fps on curr. lvl)
• (d)Conan – missing textures (logged) (hangs during loads 50%-logged)
• (d)GOW3[Accurate Getllar?} ~20 fps, minor gfx issues, little unstable
• (d)MotorStorm(2-revenge,devil)[WCB] – gfx issues
• NFL Blitz(v1.0) – Exploding vertices(logged)| Settings: SPU=2
• Ridge Racer 7(3D)(25-special events) – Tree flickering (logged)
• (d)Splatterhouse(1-surv.)(eur)PPU mem crashes (PPU Inter. for areas like start of chapters-but 15 fps - logged)
• Wipeout HD(1-Fury)(v2.51)[WCB for bloom] Little slow (~25 at start on 1st lvl, usually 60 after 1st laps, 40 on lows)
• Force Unleashed 2 – Hangs on load
• Split Second [WCB (fixes bg)] – ~8 fps, Bad gfx
• Double Dragon Neon – Broken gfx (background-logged)

@altiereslima

This comment was marked as outdated.

Copy link

commented Jan 17, 2019

@stride21

This comment has been minimized.

Copy link

commented Jan 17, 2019

In this PR the mini map flickers various colors when near objectives but when close to enemies it starts flickering stars of various colors and sizes all over the screen. With no enemies or objectives near by on the mini map everything seems the same as master.

PR:
pr flickering
Master:
no flicker master
PR:
stars pr
Master:
new
rpcs3 log.zip

@kd-11 kd-11 force-pushed the kd-11:master branch from fd5e41c to f30f0fd Jan 18, 2019

@MarioSonic2987

This comment has been minimized.

Copy link

commented Jan 18, 2019

Improves foliage rendering in Red Dead Redemption.

Before:
image
image

After:
image
image

@kd-11 kd-11 force-pushed the kd-11:master branch from f30f0fd to 2d606c7 Jan 18, 2019

@stride21

This comment has been minimized.

Copy link

commented Jan 18, 2019

Infamous 2 regression is now fixed with the recent commit.

Master:
master
PR:
motorstorm pr

Master:
master bullet holes
PR:
pr bullet holes

@stride21

This comment has been minimized.

Copy link

commented Jan 19, 2019

Battlefield: Bad Company and Ratchet and Clank Future: Tools of Destruction have exploding vertices in this PR. Bad Company has it when destroying walls and Tools of Destruction has it multiple places like when enemies attack or explode and while grinding on the rails.

Master:
master wall
PR:
pr bf
RPCS3.log.gz

Master:
ratchet master
PR:
ratchet and clank
RPCS3.log.gz

@legend800

This comment has been minimized.

Copy link

commented Jan 19, 2019

Whoa, did some perf testing with the latest build and I gained close to +3 fps across several games. Nice work!

I think you may have fixed those horizontal line artifacts on GOW3/Ascension effects too. Someone else will need to confirm as I can't get past the first area due to low fps + timing on QTE.

2019-01-18 22_46_23-fps_ 12 81 _ vulkan _ 0 0 5-ad7f3fa2-kd-11_master _ god of war iii bcus98111

@legend800

This comment has been minimized.

Copy link

commented Jan 19, 2019

Wow, you just made NFL Blitz FULLY playable by fixing this:
#5132

2019-01-18 23_10_42-fps_ 60 00 _ vulkan _ 0 0 5-ad7f3fa2-kd-11_master _ nfl blitz npub30665

2019-01-18 23_10_27-fps_ 60 04 _ vulkan _ 0 0 5-ad7f3fa2-kd-11_master _ nfl blitz npub30665

Wipeout HD has those exploding vertices/lines regression:

2019-01-18 23_34_03-

@MarioSonic2987

This comment has been minimized.

Copy link

commented Jan 19, 2019

Fixes some missing models in this place and trees shadows are rendered for the first time (as square shadows).

Before:
image

After:
image

Here's a better screenshot that shows clearly these improvements.

@legend800

This comment has been minimized.

Copy link

commented Jan 19, 2019

Jesus, this is getting ridiculous now. You fixed the background of Double Dragon Neon finally. This PR is unreal.

#5517

PR:
2019-01-18 23_38_11-fps_ 59 95 _ vulkan _ 0 0 5-ad7f3fa2-kd-11_master _ double dragon neon npub3076

Master:
50740393-7792e300-11a2-11e9-9321-d72d1cf14299

@MSuih

This comment has been minimized.

Copy link
Contributor

commented Jan 19, 2019

This PR breaks foliage transparency in X-men Origins
image
image
RSX capture

@Xcedf

This comment has been minimized.

Copy link

commented Jan 19, 2019

Confirm GoWIII exploding vertices particles fixed
Before:
22
After:
13

@digitaldude555

This comment has been minimized.

Copy link

commented Jan 19, 2019

screenshot_1488
screenshot 1718
UI fixed!

@kd-11 kd-11 changed the title [Testers Needed] rsx: Fixups and improvements [WIP][Testers Needed] rsx: Fixups and improvements Jan 19, 2019

@kd-11

This comment has been minimized.

Copy link
Contributor Author

commented Jan 19, 2019

The last commit needs a ton of work, a lot more than I initially anticipated, so this has been relegated to WIP while I finish the implementation. Should be ready in a few more days.

@digitaldude555

This comment has been minimized.

Copy link

commented Jan 19, 2019

screenshot 1729
Displays crystals for the first time.
screenshot 1721
No more exploding vertices.

@Xcedf

This comment has been minimized.

Copy link

commented Jan 19, 2019

MotorStorm Pacific Rift, environment random exploding verices fixed

@Illynir

This comment has been minimized.

Copy link

commented Jan 19, 2019

Ni no kuni works perfectly for me, try of remove the shader cache.

@frymezim

This comment has been minimized.

Copy link

commented Jan 20, 2019

@Illynir
Your right, it's weird though I always move hdd_dev0 to a newer build with a fresh directory just to make sure that I won't have shader cache issue.

@uaqlover

This comment has been minimized.

Copy link

commented Jan 20, 2019

fix NASCAR The Game: Inside Line [BLUS30932] and little bit performance

before

fps_ 28 83 _ opengl _ 0 0 5-7736 _ nascar the game_ inside line blus30932 1_21_2019 1_14_12 am

after

fps_ 29 98 _ opengl _ 0 0 5-b96edb69-kd-11_master _ nascar the game_ inside line blus30932 1_21_2019 12_59_29 am

@kd-11 kd-11 force-pushed the kd-11:master branch from 2d606c7 to 8172b2f Jan 21, 2019

@kd-11

This comment has been minimized.

Copy link
Contributor Author

commented Jan 21, 2019

Pushed a rewrite of the attrib frequency modifiers, hopefully nothing regressed. Retest games that were fixed by earlier versions of the PR to confirm everything is ok.

@MarioSonic2987

This comment has been minimized.

Copy link

commented Jan 21, 2019

MCLA still has the improvements from this PR:
image

@stride21

This comment has been minimized.

Copy link

commented Jan 21, 2019

Battlefield: Bad Company and Ratchet and Clank Future: Tools of Destruction regressions are now fixed. Motorstorm, Journey and Battlefield: Bad Company still have the improvements from this PR and Infamous 2 which regressed and was fixed earlier in this PR still looks the same as master.

kd-11 added some commits Jan 18, 2019

rsx/fp: Detect broken/NOP shaders automatically
- Do not compile body if the shader is of no consequence, leave as a passthrough shader
rsx: simple_array<T> improvements
- Implement move and copy ctors
gl: Blit fixup
- Typo fix. I meant to disable scissor test, not stencil test
- Also clean up and simplify/optimize the core logic
gl: Remove GL_R 'format'. There is no GL_R format, it part of the S-T…
…-Q-R enums for texture coordinate space

@kd-11 kd-11 force-pushed the kd-11:master branch from 5bc8b39 to 6453d70 Jan 22, 2019

@kd-11

This comment has been minimized.

Copy link
Contributor Author

commented Jan 22, 2019

Retest.

@Aurez

This comment has been minimized.

Copy link

commented Jan 22, 2019

It was quick !!
image1
Fixed: Nice job!

@thx4ever

This comment was marked as off-topic.

Copy link

commented Jan 22, 2019

My problem stills there

image

@stride21

This comment has been minimized.

Copy link

commented Jan 23, 2019

Journey regression is now fixed.
fixed

@thx4ever

This comment has been minimized.

Copy link

commented Jan 23, 2019

I tested RED DEAD REDEMPTION with this PR, and it dont get any further anymore, it stop emulator with this message: F {RSX [0x0148a24]} RSX: class std::runtime_error thrown: Verification failed (e=0x7f):
(in file c:\projects\rpcs3\rpcs3\emu\rsx\vk\vkoverlays.h:229), i don`t have tryed with opengl but vulkan it stops
Intel i7 7700
Nvidia Geforce GTX 1050
8GB RAM DDR4

@Xcedf

This comment has been minimized.

Copy link

commented Jan 23, 2019

@thx4ever flickerig polygon problem in Ghost Recon is also presented on master, and older builds, nothing to do with this PR
6

@Kravickas

This comment has been minimized.

Copy link
Contributor

commented Jan 23, 2019

GTA V
OGL
Master: ok
PR: black screen
new error E {RSX [0x00452f0]} RSX: OOM Error: Ring buffer was likely being used without notify() being called
RPCS3.log.gz
GTA V 5565.zip

VK is ok

@MarioSonic2987

This comment has been minimized.

Copy link

commented Jan 23, 2019

Fixes color regression caused by #5146 with OpenGL in Worms Crazy Golf.

Before:
image

After:
image

kd-11 added some commits Jan 23, 2019

vk: Spec fixups
- Disable DEPTH<->RGBA typeless transfers for now as they require a lot more work to work for all vendors
- Do not allow switching layouts to UNDEFINED/PREINITIALIZED formats

@kd-11 kd-11 force-pushed the kd-11:master branch from 2884f26 to 6efc71a Jan 23, 2019

@Kravickas

This comment has been minimized.

Copy link
Contributor

commented Jan 23, 2019

GTA V OGL fixed

@MarioSonic2987

This comment has been minimized.

Copy link

commented Jan 24, 2019

Trees shadows are now correct in MCLA.
image

@kd-11 kd-11 merged commit 660bfea into RPCS3:master Jan 25, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@keem85

This comment was marked as off-topic.

Copy link

commented Jan 25, 2019

Ahh cool. Will that fifo fix potentially fix the Diablo 3 freeze issue?

@tesla2105

This comment was marked as off-topic.

Copy link

commented Jan 25, 2019

@kd-11 Is it possible to fix the double speed issue in "Tales of" games (Xillia 1&2 and Graces F)? They should run 60fps in battles and menus, and 30fps everywhere else. I'm asking this, because they play really fast on this emulator. If you can fix the double speed issue, and maybe crash issue after instaling the DLC, it would be perfect.

@arcadee1977

This comment was marked as off-topic.

Copy link

commented Feb 6, 2019

GOD OF WAR 3 random freeze , display:
E {RSX [0x06fe380]} RSX: FIFO error: possible desync event x "number Unlimited increase"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.