Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InstallPup: Fix exception on newline trim #5716

Merged
merged 1 commit into from Mar 13, 2019

Conversation

Projects
None yet
3 participants
@AniLeo
Copy link
Contributor

AniLeo commented Mar 13, 2019

Avoid throwing fatal error when installing firmware without a \n character on the version string
Fixes #5646

InstallPup: Fix exception on newline trim
Avoid throwing fatal error when installing firmware without a \n character on the version string
Fixes #5646

@AniLeo AniLeo added the Bugfix label Mar 13, 2019

@Nekotekina Nekotekina merged commit 3b01e59 into RPCS3:master Mar 13, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@AniLeo

This comment has been minimized.

Copy link
Contributor Author

AniLeo commented Mar 13, 2019

I'm pretty sure that's impossible, this only touches the InstallPup function on the emulator side

@Josivan88

This comment has been minimized.

Copy link

Josivan88 commented Mar 13, 2019

@AniLeo you are right, this was not the version, please remove the comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.