Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Envy and Skyline themes #5789

Merged
merged 28 commits into from Apr 20, 2019
Merged

Add Envy and Skyline themes #5789

merged 28 commits into from Apr 20, 2019

Conversation

@ghost
Copy link

@ghost ghost commented Apr 3, 2019

Envy:





Skyline:





Skyline (Nightfall):





@ghost ghost changed the title Add Envy theme Add Envy and Skyline themes Apr 4, 2019
@hyperspeedgx
Copy link

@hyperspeedgx hyperspeedgx commented Apr 5, 2019

Dat Skyline is gorgeous, can you add a Skyline Dark too, so we can have almost the same look from the dark mode of the rpcs3 offcial page? :D

https://rpcs3.net/blog/

Edit: Beautiful!! <3

@13xforever
Copy link
Contributor

@13xforever 13xforever commented Apr 5, 2019

Shouldn't progress bar gradient be from 0 to 100% instead of from 0 to current position? So it will be revealed instead of stretching with the progress.

@ghost
Copy link
Author

@ghost ghost commented Apr 5, 2019

Shouldn't progress bar gradient be from 0 to 100% instead of from 0 to current position? So it will be revealed instead of stretching with the progress.

This sounds great, but I'm not sure how to accomplish it in Qt styling.

@AniLeo AniLeo added the GUI label Apr 5, 2019
@Hopefullyidontgetbanned
Copy link

@Hopefullyidontgetbanned Hopefullyidontgetbanned commented Apr 5, 2019

Envy looks great! Not sure about skyline tho. its mostly rpcs3's gui that makes skyline look a bit off to me.
Mostly because the mixed colors are better used in ios styled guis. But to each their own i guess

@ghost
Copy link
Author

@ghost ghost commented Apr 8, 2019

Alright, themes are ready for review.

@Johndeep
Copy link
Contributor

@Johndeep Johndeep commented Apr 10, 2019

I somehow really like Envy, since the dark is not completely black (which is somehow really tiring for my eyes), but a gentle warm dark (could be a little tad brighter, but the color palette is already top!)

It would be nice, if anyone would revert or even fix the qt autoscaling issue, which causes the crazy scaling in Linux though, then the theme might also looks nice in Linux..

@MSuih
Copy link
Member

@MSuih MSuih commented Apr 15, 2019

My complaint with Envy is the progress bar. It's fine at start, but after halfway point it turns into white text on light green background which is kind of hard to see at least on my monitor. Adding something like a dark shadow around the text would improve things, but I'm not sure if Qt supports that.

Edit: Aside from that it looks great, I'd love to see these themes included in the main version.

@ghost
Copy link
Author

@ghost ghost commented Apr 15, 2019

My complaint with Envy is the progress bar. It's fine at start, but after halfway point it turns into white text on light green background which is kind of hard to see at least on my monitor. Adding something like a dark shadow around the text would improve things, but I'm not sure if Qt supports that.

AFAIK there isn't a way to add shadows or outlines to text in Qt style sheets that doesn't involve some kind of hack. I've considered changing the color myself, but given the color palette it is difficult to find a color that is legible both on the gray and the green without it looking conspicuous.

@HerrHulaHoop
Copy link
Contributor

@HerrHulaHoop HerrHulaHoop commented Apr 15, 2019

Sadly, this bug is not specific to Envy. Kuroi suffers from it as well. We need to figure out a way to outline text. That will solve all issues.

Progress_bar_bug

@AniLeo
Copy link
Member

@AniLeo AniLeo commented Apr 16, 2019

Looks good overall, just noticed something weird:

  • Why is Logging level ERROR blue instead of red on Skyline themes?

@Megamouse
Copy link
Contributor

@Megamouse Megamouse commented Apr 16, 2019

You can just change the text color of the bar with
QProgressBar { color: blue; }
or the color of the filling bar with
QProgressBar::chunk { background: blue; }

@ghost
Copy link
Author

@ghost ghost commented Apr 17, 2019

You can just change the text color of the bar with
QProgressBar { color: blue; }
or the color of the filling bar with
QProgressBar::chunk { background: blue; }

This is most certainly the case, but I don't see what you are trying to say. Do you mean one of those should be blue?

@Megamouse
Copy link
Contributor

@Megamouse Megamouse commented Apr 17, 2019

No, I was responding to HerrHulaHoop.
The color is irrelevant. I was merely pointing out what needs to be done to at least fix the color issue of the percentage in the bars

@AniLeo AniLeo merged commit 258df80 into RPCS3:master Apr 20, 2019
2 checks passed
@JOHN30011887
Copy link

@JOHN30011887 JOHN30011887 commented Apr 21, 2019

Dam, Skyline (Nightfall) looks so good :)

@AlexM71
Copy link

@AlexM71 AlexM71 commented Apr 22, 2019

Really nice work, Skyline themes are gorgerous :):)

Yahfz added a commit to Yahfz/rpcs3 that referenced this issue Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

10 participants