Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vk: Optimizations #5979

Merged
merged 2 commits into from May 17, 2019
Merged

vk: Optimizations #5979

merged 2 commits into from May 17, 2019

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented May 16, 2019

  • Fixes a bug where vk::sampler::matches would always return false because the info was never initialized. Also adds the first step of centralized resource management by managing a sampler pool instead of pushing and deleting resources every frame.

Fixes #5931

@kd-11 kd-11 added Driver: AMD Vulkan Proprietary or amdvlk AMD Vulkan driver Render: Vulkan labels May 16, 2019
@kd-11
Copy link
Contributor Author

kd-11 commented May 16, 2019

This PR is based on the other one (#5977) and carries the performance problems from that one, so beware of this.
As for performance difference, AMD driver sees the biggest uplift here, gaining upto 25% in some cases.

@Whatcookie
Copy link
Member

ninjawindowshigher
performance on windows is much higher now

@Emulator-Team-2
Copy link

Emulator-Team-2 commented May 16, 2019 •
edited

Ratchet & Clank

PR:
1

Master:
2

Midnight Club: Los Angeles

PR:
1

Master:
2

Red Dead Redemption

PR:
1

Master:
2

P5 // RSX Utilization

PR: // RSX utilization is 27% higher than on the master build, when rpcs3 window is active.
1

PR: // rpcs3 window is inactive
1

Master:
2

@kd-11 kd-11 merged commit e3f68c6 into RPCS3:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Driver: AMD Vulkan Proprietary or amdvlk AMD Vulkan driver Render: Vulkan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ninja gaiden sigma windows and linux performance gap
3 participants
@kd-11 @Whatcookie @Emulator-Team-2