Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Util: Detect presence of TSX_Force_Abort and print to log if detected #6045

Merged
merged 1 commit into from Jun 1, 2019

Conversation

Whatcookie
Copy link
Member

@Whatcookie Whatcookie commented Jun 1, 2019

This way we can see if people have the TSX eratta fix without asking them to look up their microcode, and then referencing with several old tables.

We're not actually interested in the capabilities of TSX_Force_Abort itself, but the presence of it should confirm that the eratta fix is present.

I used https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/x86/include/asm/cpufeatures.h as reference.

FA1
FA2

@MSuih
Copy link
Member

MSuih commented Jun 1, 2019

Shoudn't the branch be a else-if, or at least above the "disabled by default" check?

@Whatcookie
Copy link
Member Author

I figured it shouldn't matter since there should be no cpu where both are true, but I guess it doesn't hurt to put it above the "disabled by default" check.

@Nekotekina Nekotekina merged commit f90f68d into RPCS3:master Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants