Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More warning fixes #6142

Merged
merged 7 commits into from Jul 1, 2019

Conversation

@MSuih
Copy link
Contributor

commented Jun 28, 2019

Continuing the work started in #5964, but this time by using MSVC with CMake. Doesn't fix every warning but cleans up a lot of the mess that was being spat out by the compiler.

rpcs3/Emu/RSX/CgBinaryProgram.h Outdated Show resolved Hide resolved
rpcs3/Emu/RSX/CgBinaryProgram.h Outdated Show resolved Hide resolved
rpcs3/rpcs3qt/qt_utils.cpp Outdated Show resolved Hide resolved
@MSuih MSuih force-pushed the MSuih:warnings branch from cd7e9b5 to dee60dd Jun 28, 2019
@MSuih MSuih force-pushed the MSuih:warnings branch from dee60dd to b195739 Jun 29, 2019
rpcs3/Emu/Cell/Modules/cellHttpUtil.cpp Outdated Show resolved Hide resolved
Utilities/File.cpp Outdated Show resolved Hide resolved
@MSuih MSuih force-pushed the MSuih:warnings branch from b195739 to ffde016 Jun 29, 2019
@MSuih MSuih force-pushed the MSuih:warnings branch from ffde016 to 7e21189 Jun 29, 2019
@MSuih MSuih force-pushed the MSuih:warnings branch from 7e21189 to 399f4f3 Jun 30, 2019
MSuih added 7 commits Jun 28, 2019
These are technically UB but work just fine
- Fix a typo in OpenAL
- Fix typo in cellHttp.h
- Unused variables in catch
- Use 64-bit shifts
- Use use_count with shared pointers, unique is depracated and getting removed
- Explicitly cast boolean to int
- Signed/unsigned issues with loop variables
- Fix missing return statement (the code path is unreachable, but compiler wants a return)
- */ ouside of comment
- Fix duplicate layout name
@Nekotekina Nekotekina force-pushed the MSuih:warnings branch from 399f4f3 to 690cdff Jul 1, 2019
@Nekotekina Nekotekina merged commit 690cdff into RPCS3:master Jul 1, 2019
2 of 4 checks passed
2 of 4 checks passed
continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MSuih MSuih deleted the MSuih:warnings branch Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.