Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsx: Implement separable MRT masks #6415

Merged
merged 3 commits into from
Aug 27, 2019
Merged

rsx: Implement separable MRT masks #6415

merged 3 commits into from
Aug 27, 2019

Conversation

kd-11
Copy link
Contributor

@kd-11 kd-11 commented Aug 26, 2019

Fixes #4380

@MarioSonic2987
Copy link
Contributor

MarioSonic2987 commented Aug 26, 2019

Fixes black textures, weird repeated image and black holes in GTA V.

Before:
image
image

After:
image
image

@incognitoh
Copy link

regression with Vulkan: Toy Story 3

tstory

Now has basically a black screen on the main menu/hub area. Ingame graphics also regressed. Cleared shader cache and tried different settings like blit, wcb, rcb, disable async etc..same result. however OGL seems to have not regressed.

This game is stubborn as it also still has the original regression from about a year ago #5526

gpu: gtx1070

@stride21
Copy link

This PR fixes black textures in Infamous 2 though some of them only partially . The transparent parts of the partial fixed textures change color and look as if their flickering as the camera moves.

Before:
before infamous
After:
after infamous
Before:
Before infamous 2
After:
infamous 2 after

@kd-11
Copy link
Contributor Author

kd-11 commented Aug 27, 2019

@incognitoh RSX capture needed.

@kd-11 kd-11 closed this Aug 27, 2019
@kd-11 kd-11 reopened this Aug 27, 2019
@MarioSonic2987
Copy link
Contributor

MarioSonic2987 commented Aug 27, 2019

It also fixes black textures in Infamous: Festival of Blood.

Before:
image
After:
image

@toccata10
Copy link
Contributor

JoJo health bars: problem solved here, on linux. Thanks.

@MarioSonic2987
Copy link
Contributor

There's a black part of the screen in Just Cause 2 with Vulkan. With OpenGL, it looks like master in both backends.
image
image

RSX Capture (Vulkan PR)

@Xcedf
Copy link

Xcedf commented Aug 27, 2019

Dante's Inferno regressed on the last commit
Before:
screenshot-2019_08_27_10_35_38
After:
screenshot-2019_08_27_10_39_19
Rsx capture
https://mega.nz/#!aQZzASrI!GafxJhcOsRq418xXq8bmahWSpwhe9OjzuIalYoHsv8o

@incognitoh
Copy link

@kd-11
Copy link
Contributor Author

kd-11 commented Aug 27, 2019

Should be fixed now. There was an existing regression in surface cache that got uncovered by this PR.

@incognitoh
Copy link

yup, Toy Story 3 vulkan works again. The original regression from last year remains but I'm sure that will be addressed someday by a different pr.

@MarioSonic2987
Copy link
Contributor

Just Cause 2 regression is fixed:
image

@ghost
Copy link

ghost commented Aug 27, 2019

@kd-11

Issue #6259 is semi-fixed with this, and by semi-fixed I mean that the effects work for a limited amount of time before they becomes absent (20-30 seconds of gameplay)

You are onto something but the issue is not entirely fixed.

Huge thanks though!

kd-11 added 3 commits August 27, 2019 17:31
- This allows creating buffers with no MAP bits set which should ensure they are created for VRAM usage only
- TODO: Implement compute kernels to avoid software fallback mode for pack/unpack operations
- Also refactors and simplifies some common code in surface store and rsx core
- Fixes crash on capture replay
@Xcedf
Copy link

Xcedf commented Aug 27, 2019

Dante's Inferno fixed

@kd-11 kd-11 merged commit 64aff7f into RPCS3:master Aug 27, 2019
@incognitoh
Copy link

@kd-11

Found another regression. Total black screen now after this pr was merged. both ogl and vk are affected.

previous master:
rpcs3 (1)

master with this pr:
rpcs3 (2)

rsx cap: https://mega.nz/#!EQ8SlQwJ!JnWo8LueuSWRdOfdbAkd4txvfkhYhFeHaqhPanehEEc

@kd-11
Copy link
Contributor Author

kd-11 commented Aug 28, 2019

@incognitoh Should be fixed by #6436. I messed up the setup for a certain type of framebuffer that is rarely used.

@stachuATX7
Copy link

image

I need to admit that older version works good. 0.0.4/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing health bars on Jojo [BLUS31405] on AMD after #4265
7 participants