Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cellGem and sceNpTrophyRegisterContext improvements #6601

Merged
merged 2 commits into from
Nov 27, 2019
Merged

cellGem and sceNpTrophyRegisterContext improvements #6601

merged 2 commits into from
Nov 27, 2019

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Sep 21, 2019 •
edited
Loading

  • Check if attribute->max_connect is zero in cellGemInit.
  • Emulate side-effects of cellGemInit allocating an internal buffer if memory_ptr provided is nullptr. (freed at cellGemEnd)
  • Fix state reset of cellGem.
  • Avoid calling lv2_obj::sleep sequantially in sceNpTrophyRegisterContext. (doesnt depend on usleep timers accuracy setting, faster respond after calling Emu.Stop(), lv2_obj::sleep doesnt need to be called on already sleeping thread)
  • cellGem is now thread-safe.
  • Make sceNpTrophyRegisterContext "queued" counter access thread-safe.

@elad335 elad335 force-pushed the ppu_cx branch 3 times, most recently from 594b551 to 8de3a49 Compare September 21, 2019 11:47
@elad335 elad335 changed the title SPPU LLVM/cellGem: tiny fixes SPU LLVM/cellGem: tiny fixes Sep 21, 2019
@Megamouse Megamouse changed the title SPU LLVM/cellGem: tiny fixes SPU LLVM/cellGem/cellTrophy: tiny fixes Sep 22, 2019
@Megamouse Megamouse changed the title SPU LLVM/cellGem/cellTrophy: tiny fixes SPU LLVM/cellGem/sceNpTrophy: tiny fixes Sep 22, 2019
@elad335 elad335 force-pushed the ppu_cx branch 8 times, most recently from 691f680 to 562f31f Compare September 27, 2019 09:56
@incognitoh
Copy link

regression.. Sly Cooper: Thieves in Time [NPUA80875] no longer boots with this pr- 0.0.7-892a06d3

pr1

@elad335
Copy link
Contributor Author

elad335 commented Sep 27, 2019

Fixed.

@elad335 elad335 force-pushed the ppu_cx branch 4 times, most recently from 4350f94 to e6177e3 Compare October 4, 2019 02:58
@elad335 elad335 force-pushed the ppu_cx branch 4 times, most recently from 8bf51ef to d79b65f Compare October 11, 2019 06:05
@AniLeo AniLeo requested a review from Nekotekina October 14, 2019 12:56
@elad335 elad335 force-pushed the ppu_cx branch 2 times, most recently from 4fed322 to daf1b6f Compare October 20, 2019 17:15
@elad335 elad335 changed the title SPU LLVM/cellGem/sceNpTrophy: tiny fixes cellGem/sceNpTrophy: tiny + misc fixes Oct 29, 2019
@elad335 elad335 changed the title cellGem/sceNpTrophy: tiny + misc fixes cellGem: tiny + misc fixes Nov 6, 2019
@elad335 elad335 changed the title cellGem: tiny + misc fixes cellGem and ppu scheduler improvements Nov 27, 2019
@elad335
Decrease memory stats in cellGemInit if needed
855eaa4 
Also:
* fix state reset of cellGem
* Check max_connect == 0 in cellGemInit
@elad335
Avoid calling lv2_obj::sleep sequantially in sceNpTrophyRegisterContext
fb7620c 
Also fix a correctness issue with queued.
@elad335 elad335 changed the title cellGem and ppu scheduler improvements cellGem and sceNpTrophyRegisterContext improvements Nov 27, 2019
@Megamouse Megamouse merged commit 038c6bb into RPCS3:master Nov 27, 2019
@elad335 elad335 deleted the ppu_cx branch November 27, 2019 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Megamouse Megamouse Megamouse left review comments

@Nekotekina Nekotekina Awaiting requested review from Nekotekina

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elad335 @incognitoh @Megamouse