Enable in-game reload of some settings #6792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
in my testing of this pr if you change the per game settings they don't apply until you go into the main settings menu and click save but past that it seems to work fine. |
|
@money123451 should work now. |
|
it works as it should now. |
kd-11
reviewed
Nov 27, 2019
| @@ -625,16 +660,59 @@ namespace rsx | |||
| const f32 x_stride = f32(w) / m_datapoint_count; | |||
| const u32 tail_index_offset = m_datapoints.size() - m_datapoint_count; | |||
|
|
|||
| for (u32 i = 0; i < m_datapoint_count; ++i) | |||
| for (size_t i = 0; i < m_datapoint_count; ++i) | |||
There was a problem hiding this comment.
whats going on here? this change and the one below it seem pointless...unless I missed something.
There was a problem hiding this comment.
Some random warning I was getting. It fixed some green wavey underlined text in VS 🤷♂️
There was a problem hiding this comment.
It's a good change correctness wise though, especially when indexing arrays it's healthy to use a machine word size data type.
kd-11
approved these changes
Nov 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable the dynamic reapplication of certain settings during game play after saving the settings dialog. Further settings might be unlocked accordingly in the future.
The currently unlocked settings are:
all the settings for the performance overlay,
all the settings for the shader compilation hint,
all the settings for the shader compilation screen (although currently only applies whenever the screen is spawned),
show trophy popups,
auto-start,
auto-exit,
start with fullscreen,
show fps in title