cellVoice/cellAudio Fixes #6862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
force-pushed
the
sys_prx
branch
6 times, most recently
from
21e0b22 to
09695ce
Compare
elad335
commented
Oct 26, 2019
| attr->name_u64 = 0; | ||
|
|
||
| for (u64 i = 0; i < MAX_AUDIO_EVENT_QUEUES; i++) | ||
| { | ||
| // Create an event queue "bruteforcing" an available key | ||
| const u64 key_value = 0x80004d494f323221ull + i; | ||
|
|
||
| if (const s32 res = sys_event_queue_create(id, attr, key_value, 32)) |
There was a problem hiding this comment.
Any reason this was 32 before? this is certainly incorrect looking at firmware values but im asking in case it is a workaround for something.
|
There is not too much audio related fixes, so i gave a try, old UT3 bug: No luck, so far. |
|
It ain't about sound quality. |
|
Spelunker has a bug that few seconds that a game is started the music tempo goes normal to slow. |
|
if it isn't a regression from this pr do not report. |
* Use shared lock wherever possible. * Fix cellVoiceSetVolume. * Fix error logging of cellVoiceCreateNotifyEventQueue, cellAudioCreateNotifyEventQueue
TODO: global sdk value used is set in cellAudioInit, which means sdk var value is 0 before it's initialization, currently safely set queue size to 8 in this case.
AniLeo
approved these changes
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other improvements:
Fixes #6884
Fixes Test Drive Unlimited.