Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys_spu: Fix SNR and Inbound Mailbox state reset #6864

Merged
merged 2 commits into from
Oct 29, 2019
Merged

sys_spu: Fix SNR and Inbound Mailbox state reset #6864

merged 2 commits into from
Oct 29, 2019

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Oct 24, 2019 •
edited
Loading

  • Don't reset SPU SNR channels after sys_spu_thread_group_start/exit.
  • Reset SPU mailbox only after thread exit or external termination. (sys_spu_thread_group_start doesn't reset).
  • Remove bugged ESTAT check at sys_spu_thread_write_spu_mb. (both testcase and firmware disasm confirm this check doesn't exist)

testcase
Results on rpcs3 master:

Testing SNR registers reset...
SNR1 channel count after sys_spu_thread_group_start = 0x0
SNR1 channel count after sys_spu_thread_exit = 0x0
Testing Mailbox reset...
"sys_spu_thread_write_spu_mb(thr_id, 0)" Failed at line 77! (error=0x8001000f)

Results on realhw:

Testing SNR registers reset...
SNR1 channel count after sys_spu_thread_group_start = 0x1
SNR1 channel count after sys_spu_thread_exit = 0x1
Testing Mailbox reset...
Mailbox channel count after sys_spu_thread_group_start = 0x4
Mailbox channel count after sys_spu_thread_exit = 0x0
Mailbox channel count after sys_spu_thread_group_terminate = 0x0

@elad335 elad335 changed the title sys_spu: Fix SNR and Inbound Mailbox stare reset sys_spu: Fix SNR and Inbound Mailbox state reset Oct 24, 2019
@elad335 elad335 force-pushed the snr_mailbox branch 2 times, most recently from 01aecca to d0f0623 Compare October 24, 2019 19:26
@elad335 elad335 mentioned this pull request Oct 25, 2019
Closed
6 tasks
@elad335
sys_spu: Fix SNR and Inbound Mailbox state reset
864093d 
Also remove bugged ESTAT check at sys_spu_thread_write_spu_mb.
@Nekotekina Nekotekina merged commit b99992d into RPCS3:master Oct 29, 2019
@elad335 elad335 deleted the snr_mailbox branch October 29, 2019 16:38
elad335 added a commit to elad335/rpcs3 that referenced this pull request Oct 29, 2019
@elad335
sys_spu Fixup after RPCS3#6864
f5ec411
Nekotekina pushed a commit that referenced this pull request Oct 29, 2019
@elad335 @Nekotekina
sys_spu Fixup after #6864
f41f505
kd-11 pushed a commit to kd-11/rpcs3 that referenced this pull request Nov 2, 2019
@elad335 @kd-11
sys_spu Fixup after RPCS3#6864
696f1ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elad335 @Nekotekina