rsx: Enable primitive restart index only when needed #6889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kd-11
reviewed
Oct 28, 2019
kd-11
reviewed
Oct 28, 2019
kd-11
reviewed
Oct 28, 2019
kd-11
pushed a commit
to kd-11/rpcs3
that referenced
this pull request
Nov 2, 2019
* rsx: Enable primitive restart index only when needed * rsx: Use if with initializer in read_put()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default restart index value is UINT32_MAX so it's not unlikely that we enabled the restart index when there's no need to.
edit: disabled primitive restart array may be faster to process (byteswap etc) indices.