[Hotfix] vk: Add checks for alphaToOne support #6919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This feature is very rarely used, as alphaToCoverage is commonly used as a replacement for blending, not in addition to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AMD windows driver does not support alpha-to-one and crashes when alpha-to-one feature is enabled.
To properly work around this would require also emulating the whole sample masking stage but this is very rarely used due to the fact that you can just disable blending when using alphaToCoverage. I have not encountered any PS3 application that actually uses this, but if one is found, a fallback implementation could theoretically be written. Leaving that task for the future as it is not a priority.
Fixes AMD windows driver crashing on boot when MSAA is enabled (regression).