Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor changes in BufferUtils #6924

Merged
merged 2 commits into from Oct 30, 2019
Merged

Minor changes in BufferUtils #6924

merged 2 commits into from Oct 30, 2019

Conversation

Nekotekina
Copy link
Member

No description provided.

@Nekotekina
Minor cleanup in BufferUtils.cpp
b196876 
Replace inline asm with intrinsic using target attribute trick.
@kd-11
Copy link
Contributor

kd-11 commented Oct 30, 2019

Maybe it could be worth refactoring out the horizontal min/max code into helper methods to improve reusability as well.

@Nekotekina
Minor optimization in BufferUtils.cpp
e3e7051 
Don't use PSHUFB for horizontal operations.
Utilize PHMINPOSUW to compute max as well:
 + sse41_hmin_epu16
 + sse41_hmax_epu16
@kd-11
Copy link
Contributor

kd-11 commented Oct 30, 2019

Thanks!

@Nekotekina Nekotekina merged commit e3e7051 into RPCS3:master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nekotekina @kd-11