Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightweight putllc() for non-TSX if no data changed #6928

Merged
merged 1 commit into from Nov 19, 2019
Merged

Lightweight putllc() for non-TSX if no data changed #6928

merged 1 commit into from Nov 19, 2019

Conversation

plappermaul
Copy link
Contributor

This replaces the totally messed up PR #6728

Some games make heavy use of getllar() & putllc() without even changing data.
In this case avoid unneccesary heavy locking of the PPU threads on non-TSX
hosts.

@plappermaul
Copy link
Contributor Author

Regarding the last review comments.

  • casting was fixed.

  • the requested cmp_rdata is not needed. From my oberservation it does not help much to use this additional check before the heavy lock.

@elad335
Copy link
Contributor

elad335 commented Nov 1, 2019

res.release(..) was intentionally being put before writer_lock destructor to reduce reservation lock lifetime significantly.

This replaces the totally messed up PR #6728

Some games make heavy use of getllar() & putllc() without even changing data.
In this case avoid unneccesary heavy locking of the PPU threads on non-TSX
hosts.
@plappermaul
Copy link
Contributor Author

res.release(..) was intentionally being put before writer_lock destructor to reduce reservation lock lifetime significantly.

Fixed.

@Nekotekina Nekotekina merged commit cd6b6c8 into RPCS3:master Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants