SPU: Disable "special branch patchpoints" #6942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4654,7 +4654,7 @@ class spu_llvm_recompiler : public spu_recompiler_base, public cpu_translator | |||
|
|
|||
| if (found == m_functions.end()) | |||
| { | |||
| if (g_cfg.core.spu_verification) | |||
| if (false && g_cfg.core.spu_verification) | |||
There was a problem hiding this comment.
Does this have any benefit over commenting out via #if 0?
There was a problem hiding this comment.
Yes, #if completely disables the code. With if (false) it's still compiled, just never executed. Lesser chance to break it after refactoring.
Nekotekina
force-pushed
the
master
branch
2 times, most recently
from
d5cddb0
to
808a904
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
atomic2 commits don't affect RPCS3 at the moment because unused.