Minor exception removal #6961
Merged
Minor exception removal #6961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
reviewed
Nov 8, 2019
| @@ -541,7 +541,7 @@ constexpr u32 operator""_u32(const char* s, std::size_t length) | |||
| // Convert 8-byte string to u64 value like reinterpret_cast does | |||
| constexpr u64 operator""_u64(const char* s, std::size_t length) | |||
| { | |||
| return length != 8 ? throw s : | |||
| return | |||
There was a problem hiding this comment.
Consider for each character to check existence, for example character 8 can be read as: to_u8(length >= 8 ? s[7] : '\0')
There was a problem hiding this comment.
That looks redundant unless there is some use case for shorter strings. It can just become "consteval" function in C++20, and explicit length checks will become redundant.
Use fs::get_virtual_device properly.
Since it's Windows-only functionality with limited use.
Gradual exception deprecation: disallow choosing exception type. However, the function itself can remain here forever.
Since there is spu_runtime::g_escape function now.
Use std::from_chars plus minimal hex prefix support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bits of exception removal.
Also potential minor bugfix related to network share locations on Windows.