Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Graphs #6974

Merged
merged 2 commits into from Nov 12, 2019
Merged

Performance Graphs #6974

merged 2 commits into from Nov 12, 2019

Conversation

VelocityRa
Copy link
Member

@VelocityRa VelocityRa commented Nov 9, 2019

Description

  • Used for framerate & frametime in this PR, extendable to anything else.
  • Features dynamic scaling and horizontal guide lines.
  • They're enabled on High detail mode.

I can't be bothered to make them configurable currently, I guess someone else can do it.

Related issues: #4500, #6892 (comment)

Screenshot

image

Video

IMAGE ALT TEXT

@VelocityRa VelocityRa force-pushed the perf-graph branch 2 times, most recently from 7d38220 to ab910ee Compare November 9, 2019 23:48
@illusion0001
Copy link
Contributor

Great work! 🎉

Megamouse
Megamouse previously approved these changes Nov 10, 2019
@dio-gh
Copy link
Contributor

dio-gh commented Nov 11, 2019

Something changed with how the position of the perf overlay is handled. The overlay for me is set to be 25px 25px away from the top right corner, but with this PR it gets shifted down into the middle of the screen for some reason:

image

There's also an issue with the amount of text, but I guess that's because of the font size I set.

Otherwise it's working as intended, great work!

@VelocityRa
Copy link
Member Author

  • Fixed positioning bug in top quadrants
  • Made font size 80% of main performance overlay's font

@ruthan
Copy link

ruthan commented Nov 11, 2019

Some better legend (description) to graphs would help, now its not clear what is difference between 1st and 2nd graph, at least is not intuitive - description is the same.

@Asinin3
Copy link
Contributor

Asinin3 commented Nov 11, 2019

@ruthan If you don't know the difference between framerate and frametime im not so sure you should be looking at a performance graph to begin with :/ And a legend just takes up space needlessly

@dio-gh
Copy link
Contributor

dio-gh commented Nov 11, 2019

Can confirm the alignment and size issues being fixed:
image

@ruthan
Copy link

ruthan commented Nov 12, 2019

@Asinin3 Im blind or picture was replaced, i thing that it was replaced..

@RainbowCookie32
Copy link
Contributor

It wasn't. You can check the edit history on GitHub comments. It was always that picture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants