Performance Overlay: Add graph settings and fix some minor issues #6987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One of the graphs must be enabled in order for FPS counter and CPU usage to work. (with low lvl overlay) |
|
That's probably in master as well |
|
Yes, but it looked to me that u fixing some of the regressions after perf graph pr. nvm 🤷♂ |
|
That's cool. I Just wanted to make sure it wasn't caused by my changes. |
elad335
reviewed
Nov 13, 2019
Megamouse
force-pushed
the
fix_overlay_stuff
branch
2 times, most recently
from
bf710a4
to
d15fa44
Compare
this is done to prevent severe conflicts with upcoming changes
Megamouse
force-pushed
the
fix_overlay_stuff
branch
from
d15fa44
to
717cd21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds individual settings for the framerate graph and the frametime graph and detaches them from the "High" detail level.
Fixes a division by zero bug where the chip usage would show "-nand(ind)".
Moves code to a new header file.
Fixes the vertical center option when graphs are shown.
Disables the overlay margin options in the settings dialog while the center option is enabled.
Disclaimer:
I noticed that the graphs adjust to the body width while the graph description does an auto-resize instead. I probably won't fix it in this PR.