Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intel iGPU needs workaround on Windows #6994

Merged
merged 1 commit into from Nov 15, 2019
Merged

Intel iGPU needs workaround on Windows #6994

merged 1 commit into from Nov 15, 2019

Conversation

Anuskuss
Copy link
Contributor

No description provided.

@kd-11
Copy link
Contributor

kd-11 commented Nov 15, 2019

I remember this being tested and reported to work. So does it not work at all anymore? Does it work only for some iGPUs and not others? Did the drivers change? Maybe whoever reported it working did not test correctly? A lot of information is missing here.

@Anuskuss
Copy link
Contributor Author

Anuskuss commented Nov 15, 2019

Whatcookie removed the Untested comment stating that it works in ANV; maybe nobody tested it on Windows?
Btw it works as intended without the workaround when running --no-gui, but that doesn't support SPU LLVM yet and only works on ASMJIT about 50% of the time.

@kd-11
Copy link
Contributor

kd-11 commented Nov 15, 2019

So the intel does report window changes but only when there is no other GUI windows? Interesting.

@kd-11 kd-11 merged commit 7e31c30 into RPCS3:master Nov 15, 2019
@Anuskuss
Copy link
Contributor Author

Just to clarify: With "works as intended" I was referring to (exclusive) fullscreen. If I run --no-gui the window would still be broken. Also I can't reproduce the white screen (whole screen is white & RPCS3 hangs) on ASMJIT with --no-gui anymore, it just works everytime now (on the old build).
Anyway, the patch fixes this for good and I don't get any (visible) performance loss.

@Anuskuss
Copy link
Contributor Author

@kd-11 Sorry for all the noise but turns out that you were right and this is indeed a regression in the driver 🤷‍♂️ So I'd say we (you) revert this and we bank on Intel to fix this at some point.
For future readers: 26.20.100.7372 introduced the bug so you should be on / downgrade to 26.20.100.7212 if you care about Fullscreen in Vulkan on RPCS3.

@kd-11
Copy link
Contributor

kd-11 commented Nov 17, 2019

No need to revert, it should work fine even with the other method and banking on intel fixing anything is generally a bad idea. At best, I will review their drivers before the next version tag and revert if it has been fixed by then.

@Anuskuss
Copy link
Contributor Author

Alright but you don't need to worry about it since I frequently check for a new driver update anyway, I'll keep the old version around and ping you here when Intel finally fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants