Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPU LLVM bugfixes #7005

Merged
merged 2 commits into from
Nov 17, 2019
Merged

SPU LLVM bugfixes #7005

merged 2 commits into from
Nov 17, 2019

Conversation

Nekotekina
Copy link
Member

Thanks to @Niram7777 for research.

@Nekotekina
SPU LLVM: change patchpoint name generation
f30b81f 
Allow 2 or more patchpoint from a single address.
@Nekotekina
SPU LLVM: use updateGlobalMapping instead of addGlobalMapping
db4e201 
...Where appropriate.
Fix to incorrect addGlobalMapping usage.
Also use clearAllGlobalMappings at compilation start.
@fifazalata
Copy link

tested this & it seems to have fixed the slowdown that has been introduced in #6982
at least for me with my i7 2600k @3.4
btw sorry for not properly testing before as I had exams this past week
anyway, here is a log after I tested NieR in case you need it
RPCS3.log.gz

@Niram7777 Niram7777 mentioned this pull request Nov 17, 2019
Closed
Niram7777
Niram7777 approved these changes Nov 17, 2019
View reviewed changes
Copy link
Contributor

@Niram7777 Niram7777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more assertion failure related from addGlobalMapping.

@Nekotekina Nekotekina merged commit db4e201 into RPCS3:master Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Niram7777 Niram7777 Niram7777 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nekotekina @fifazalata @Niram7777