Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys_net: Add error_code #7020

Merged
merged 1 commit into from
Nov 21, 2019
Merged

sys_net: Add error_code #7020

merged 1 commit into from
Nov 21, 2019

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Nov 21, 2019

No description provided.

@elad335 elad335 closed this Nov 21, 2019
@elad335 elad335 reopened this Nov 21, 2019
@elad335 elad335 force-pushed the sys_net_ec branch 2 times, most recently from 09faa4e to 1b94740 Compare November 21, 2019 17:41
@Nekotekina
Copy link
Member

Nekotekina commented Nov 21, 2019

I don't like the idea of negating enum constant values. Can possibly overload operator- for it:

constexpr sys_net_error operator-(sys_net_error v)
{
  return sys_net_error{-+v};
}

@elad335
Copy link
Contributor Author

elad335 commented Nov 21, 2019

Done.

@elad335 elad335 force-pushed the sys_net_ec branch 5 times, most recently from 18b963f to f968906 Compare November 21, 2019 19:05
@Nekotekina Nekotekina merged commit 6ad8b0a into RPCS3:master Nov 21, 2019
@elad335 elad335 deleted the sys_net_ec branch November 21, 2019 19:52
@RPCS3 RPCS3 locked as off-topic and limited conversation to collaborators Nov 22, 2019
@RPCS3 RPCS3 deleted a comment Nov 22, 2019
@AniLeo
Copy link
Member

AniLeo commented Nov 22, 2019

Do not false flag regressions on unrelated PRs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants