Annoying refactoring #7029
Merged
Annoying refactoring #7029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nekotekina
force-pushed
the
master
branch
2 times, most recently
from
757ef33 to
24b6b11
Compare
Use struct (spu_program) instead of std::vector<u32>.
Nekotekina
force-pushed
the
master
branch
2 times, most recently
from
8fd14e1 to
072c5cd
Compare
Margen67
reviewed
Nov 26, 2019
| @@ -15,14 +15,12 @@ error_code sys_gpio_get(u64 device_id, vm::ptr<u64> value) | |||
| return CELL_ESRCH; | |||
| } | |||
|
|
|||
| if (!vm::check_addr(value.addr(), value.size(), vm::page_writable)) | |||
| // Retail consoles dont have LEDs or DIPs switches, hence always sets 0 in paramenter | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't improve anything for end users, but may break something.