ds4: Add workarounds for some 3rd party controllers #7059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megamouse
reviewed
Dec 3, 2019
- Simplify helpers to read integers HID feature report buffers. They're simple LE values. - Improve calibration format detection by just checking the returned values and not relying on bluetooth check. PS4 does not seem to do it this way as it accepts 3rd party controllers with inverted format. The only other request 0xA3 seems unrelated to device capabilities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I was messing around with some non-OEM ds4 clone and found it has some broken HID reports, specifically 0x81 (get mac address). The actual PS4 seems to use 0x12 instead (another command to get bluetooth radio mac address) so I tried using that instead and it works. Also, the calibration data seems to be in bluetooth mode when the controller is not genuine, something which is likely fixed in the real console by just checking if value is less than 0 and not whether its connected via bluetooth, but that's an issue for another day. Checked the same changes into the linux kernel driver for ds4 and it does get the controller to work. Ofc if you get the genuine check error with something you paid full price for, just get a refund instead.