C-style cast cleanup VI #7061
C-style cast cleanup VI #7061
Conversation
rpcs3/Emu/CPU/CPUTranslator.cpp
Outdated
| } | ||
| else if (sct->isDoubleTy()) | ||
| { | ||
| return llvm::ConstantDataVector::get(m_context, llvm::makeArrayRef((const f64*)v._bytes, 2)); | ||
| return llvm::ConstantDataVector::get(m_context, llvm::makeArrayRef(reinterpret_cast<const f64*>(v._bytes), 2)); |
There was a problem hiding this comment.
| return llvm::ConstantDataVector::get(m_context, llvm::makeArrayRef(reinterpret_cast<const f64*>(v._bytes), 2)); | |
| return llvm::ConstantDataVector::get(m_context, llvm::makeArrayRef(&std::as_const(v._f64[0]), 2)); |
There was a problem hiding this comment.
I'll leave it as is because v128 normal_array / reversed_array aren't really supposed to be used like plain C arrays
| min_index = std::min<u16>(index, static_cast<u16>(min_index)); | ||
| max_index = std::max<u16>(index, static_cast<u16>(max_index)); |
There was a problem hiding this comment.
Since index is u16 and you cast min_index and max_index, you shouldn't need to specialize functions with <u16>
There was a problem hiding this comment.
Specializing it is preferred way to use min/max though
There was a problem hiding this comment.
Sure thing - but do you then need to cast min_index and max_index? I might be wrong, but I thought it's one or the other.
There was a problem hiding this comment.
You don't need static_cast there because of implicit convertion, but it's still here to silence MSVC warning about truncation
rpcs3/Emu/RSX/GL/GLOverlays.h
Outdated
| @@ -493,7 +493,7 @@ namespace gl | |||
| } | |||
| else | |||
| { | |||
| u64 key = (u64)desc; | |||
| u64 key = reinterpret_cast<u64>(desc); | |||
| temp_image_cache[key] = std::move(std::make_pair(owner_uid, std::move(tex))); | |||
There was a problem hiding this comment.
Not related to this PR, but std::move on std::make_pair is redundant AFAIK.
rpcs3/Emu/RSX/Overlays/overlays.cpp
Outdated
| @@ -143,7 +143,7 @@ std::u16string ascii8_to_utf16(const std::string& ascii_string) | |||
|
|
|||
| for (const auto& code : ascii_string) | |||
| { | |||
| out.push_back((char16_t)code); | |||
| out.push_back(static_cast<char16_t>(code)); | |||
There was a problem hiding this comment.
Again unrelated to PR, but you should be able to do exact same pushing directly to std::u16string without an intermediate vector?
Nekotekina
force-pushed
the
master
branch
2 times, most recently
from
2b78a2a
to
bfa8e5a
Compare
rpcs3/Emu/RSX/Overlays/overlays.cpp
Outdated
| @@ -138,16 +138,18 @@ std::string utf16_to_ascii8(const std::u16string& utf16_string) | |||
|
|
|||
| std::u16string ascii8_to_utf16(const std::string& ascii_string) | |||
| { | |||
| std::vector<char16_t> out; | |||
| std::u16string out; | |||
| out.reserve(ascii_string.length() + 1); | |||
There was a problem hiding this comment.
With out changed to string, you don't need to reserve + 1 because you're not appending the null terminator no more.
No description provided.