Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix sceNpTrophyGetTrophyUnlockState #7104

Merged
merged 2 commits into from
Dec 18, 2019
Merged

Hotfix sceNpTrophyGetTrophyUnlockState #7104

merged 2 commits into from
Dec 18, 2019

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Dec 17, 2019 •
edited
Loading

It was returning unlock state of different trophies than it should lol, now fixed. (endianness typo)

@AniLeo AniLeo requested a review from Megamouse December 17, 2019 22:43
@Megamouse
Copy link
Contributor

Example?

@elad335
Copy link
Contributor Author

elad335 commented Dec 18, 2019 •
edited
Loading

Current trophies state: trophy id = 0: unlocked, trophy id = 24: locked.

Reported by this function: trophy id = 0: locked, trophy id = 24: unlocked.
Notice the number of ids im using, the state of them is swapped on master. (endianness...)

@Megamouse Megamouse merged commit 8d955cf into RPCS3:master Dec 18, 2019
@elad335 elad335 deleted the hotfix branch December 18, 2019 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Megamouse Megamouse Awaiting requested review from Megamouse

Assignees
No one assigned
Labels
Bugfix Firmware: HLE Trophies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elad335 @Megamouse @AniLeo