Make rsx::get_address report caller location #7345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
elad335
commented
Jan 30, 2020
•
- Report line and filename of caller rsx::get_address upon failure of address translation.
- Added verification for RSXIO REPORT memory for offsets out of range: offset must be lower than 10m.
- Fixes a regression in HLE cellGcmMapMainMemory from #7266, minor cleanup.
|
Code is fine and logic is sound (and needed to aid debugging) but once again #7220 stands in the way. And no, its not about ease of fixing or correctness, think of it as a fence so that any bug reports after it will refer to builds created after it is resolved. That is the whole reasoning behind a code freeze. |
elad335
force-pushed
the
patch-3
branch
6 times, most recently
from
bd4c9b4
to
6245299
Compare
|
Use the pull request build, I don't need a log of master build. |
elad335
force-pushed
the
patch-3
branch
2 times, most recently
from
a1254a2
to
7619d7e
Compare
|
RSX no longer in maintaince mode merge it. |
kd-11
reviewed
Feb 8, 2020
kd-11
reviewed
Feb 8, 2020
|
All review comments solved. |
kd-11
approved these changes
Feb 8, 2020
Fix arguments order, softcode RsxReports::report offset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.