Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rsx: Improve NV308A_COLOR #7846

Merged
merged 2 commits into from
Mar 25, 2020
Merged

rsx: Improve NV308A_COLOR #7846

merged 2 commits into from
Mar 25, 2020

Conversation

elad335
Copy link
Contributor

@elad335 elad335 commented Mar 24, 2020 •
edited
Loading

  • Fix NV308A_COLOR methods range.
  • Batch NV308A_COLOR methods execution together (optimization).
  • Fix termination of bind_range<> in rsx methods binding.
  • Reset all method registers at each boot.

Fixes #6803
Fixes #3493

@kd-11
Copy link
Contributor

kd-11 commented Mar 24, 2020

Obviously we'll need proof that these actually run on CEX. We already know for certain they crash DEX for example, and the chances that a commercial game exists that runs on CEX but crashes on DEX are highly unlikely.

@elad335 elad335 force-pushed the rsx-fifo branch 3 times, most recently from 77590d2 to 7ec1b9a Compare March 24, 2020 10:21
@Emulator-Team-2
Copy link

Emulator-Team-2 commented Mar 24, 2020 •
edited
Loading

Edit: Fixed by commit 5cf4e53.

These games still crashing:
-Flock! crashes after starting the game.
-Dragon Ball Z Ultimate Tenkaichi crashes before the title screen.

[Flock!]

E {RSX [0x7902740]} RSX: Invalid RSX method 0xb000 (arg=0x0, start=0xa400, count=0x380, non-inc=false) x4792

RPCS3.log.gz

[Dragon Ball Z Ultimate Tenkaichi]

E {RSX [0x001267c]} RSX: Invalid RSX method 0xb000 (arg=0xe810240, start=0xa400, count=0x304, non-inc=false) x5042

RPCS3.log.gz

@elad335
Copy link
Contributor Author

elad335 commented Mar 24, 2020

@Emulator-Team-2 Retest.

@Emulator-Team-2
Copy link

The latest commit fixes this issue.

@StevenMiller123
Copy link

This also fixes the crashing in J Stars.

@kd-11
Copy link
Contributor

kd-11 commented Mar 24, 2020

Can we get this properly tested on CFW? I'm not in love with the idea of going back to adding hacks just to make crashes go away. We had a testcase for this in the past, maybe we can get assistance testing it on discord.

@elad335 elad335 force-pushed the rsx-fifo branch 5 times, most recently from fcb5d8e to 7f9c784 Compare March 24, 2020 22:26
@elad335 elad335 changed the title rsx: Add range of allowed unknown FIFO methods [VERY WIP] rsx: Improve NV308A_COLOR Mar 24, 2020
@elad335 elad335 force-pushed the rsx-fifo branch 6 times, most recently from a5bf207 to 8bd7874 Compare March 25, 2020 05:02
@elad335 elad335 requested a review from kd-11 March 25, 2020 05:04
@elad335 elad335 force-pushed the rsx-fifo branch 2 times, most recently from 4788b36 to 392847b Compare March 25, 2020 05:46
@elad335
Copy link
Contributor Author

elad335 commented Mar 25, 2020

Please retest all your games which were affected by this pr.

@Emulator-Team-2
Copy link

Emulator-Team-2 commented Mar 25, 2020 •
edited
Loading

@elad335
@kd-11
@StevenMiller123

Build: 392847b
The latest build fixes broken and missing textures in:

[Dragon Ball Z Ultimate Tenkaichi]
DBZ

[Dragon Ball: Raging Blast 1]
DBR1

[Dragon Ball: Raging Blast 2]
DBR2

[J-Stars Victory VS]
J

@elad335 elad335 changed the title [VERY WIP] rsx: Improve NV308A_COLOR rsx: Improve NV308A_COLOR Mar 25, 2020
@elad335 elad335 mentioned this pull request Mar 25, 2020
Open
2 tasks
kd-11
kd-11 reviewed Mar 25, 2020
View reviewed changes
rpcs3/Emu/RSX/RSXThread.h Outdated Show resolved Hide resolved
@elad335 elad335 force-pushed the rsx-fifo branch 2 times, most recently from a486f62 to 6a6ecd4 Compare March 25, 2020 10:46
@elad335 elad335 requested a review from kd-11 March 25, 2020 10:49
@elad335 elad335 force-pushed the rsx-fifo branch 2 times, most recently from 90a24b0 to 3cf34b2 Compare March 25, 2020 10:55
@elad335 elad335 force-pushed the rsx-fifo branch 3 times, most recently from 356cfe0 to 104a5ea Compare March 25, 2020 11:32
elad335 added 2 commits March 25, 2020 13:37
@elad335
rsx: Improve NV308A_COLOR
3cb64ca 
* Fix NV308A_COLOR methods range.
* Batch NV308A_COLOR methods execution together.
* Fix termination of bind_range<> in rsx methods binding.
@elad335
rsx: Reset all method registers at rsx_state::init()
bffa15f
@elad335 elad335 requested a review from kd-11 March 25, 2020 12:33
@Nekotekina Nekotekina merged commit 158e34f into RPCS3:master Mar 25, 2020
@elad335 elad335 mentioned this pull request Mar 28, 2020
Merged
@elad335 elad335 mentioned this pull request Apr 12, 2020
Open
@elad335 elad335 deleted the rsx-fifo branch April 13, 2020 09:03
@RPCS3 RPCS3 deleted a comment from Loja181 Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kd-11 kd-11 Awaiting requested review from kd-11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@elad335 @kd-11 @Emulator-Team-2 @StevenMiller123 @Nekotekina