Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gl: Refactor shader compilation #8234

Merged
merged 3 commits into from
May 16, 2020
Merged

gl: Refactor shader compilation #8234

merged 3 commits into from
May 16, 2020

Conversation

AniLeo
Copy link
Member

@AniLeo AniLeo commented May 16, 2020

More work towards the OpenGL render, refactors all shader compilation code into using the unique gl::glsl::shader path

gl: Refactor shader compilation

  • Refactors the three existing shader compilation paths into an unique gl::glsl::compile path
  • GLVertexProgram: Removes unused interleaved var
  • gl::glsl::shader: Stores shader source on struct for usage in other places
  • gl::glsl::shader: Remove recreate() and partial constructors

gl: Refactor shader type usage

  • Removes duplicated type in gl::glsl::shader in favor of Common glsl::program_domain types: stores program_domain in the gl::glsl::shader struct and converts to OpenGL specific GLenum when needed

gl: Only log shaders if g_cfg.video.log_programs is enabled

@AniLeo AniLeo marked this pull request as ready for review May 16, 2020 07:04
@AniLeo AniLeo requested a review from kd-11 May 16, 2020 07:07
@AniLeo AniLeo force-pushed the opengl_shader branch 2 times, most recently from ec40528 to fdc7df8 Compare May 16, 2020 07:22
@AniLeo AniLeo merged commit a8bca8b into RPCS3:master May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants