feat: dialogue popup implemented #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksiek127
approved these changes
May 12, 2022
|
|
||
| viewModel = loader.getController(); | ||
| viewModel.setNpcImage(npcImage); | ||
| viewModel.setBackgroundImage("file:assets/popup-background.png"); //images do not load from fxml on my computer |
Collaborator
There was a problem hiding this comment.
might be a little problem with working with this code, maybe it's because of operating system, but it's fine as long as it works on any of our computers, the app doesn't need to be cross-platform
| viewModel.setNpcFrameImage("file:assets/npc-frame.png"); | ||
| this.setFill(Color.TRANSPARENT); | ||
|
|
||
| textPages = List.of(text.split("(?<=\\G.{200})")); //split text into 200-letter pages |
Collaborator
There was a problem hiding this comment.
splitting question into pages is nice, but we'll need a limit for answer's length, cause dividing answers into pages seems like too much for me (though it's just my opinion)
Collaborator
Author
There was a problem hiding this comment.
For now I've decided not to implement a back and forth dialogue. Thought of it as more of a guide or a quick tip for a player. I guess that's still up for debate.
| public void setPreviousButtonOnClick(EventHandler<? super MouseEvent> callback) { | ||
| previousButton.setOnMouseClicked(callback); | ||
| } | ||
| } |
mhawryluk
approved these changes
May 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist