@co012/rpg 107 actions #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksiek127
approved these changes
May 15, 2022
Collaborator
ksiek127
left a comment
ksiek127
left a comment
There was a problem hiding this comment.
got a slight doubt about this 'distance < 1.5' in controller i pointed out in comment to controller.java, but the action logic itself looks good
| popupController.openTextImagePopup("Picked up an item!", objectView.getImage(), getWindowCenterX(), getWindowCenterY()); | ||
| objectView.setVisible(false); | ||
| currentModel.removeGameObject(object); | ||
| if (distance < 1.5) { |
Collaborator
There was a problem hiding this comment.
is the distance measured by squares? if yes, then 1.5 squares means i can pick up an item that is not adjacent to my square and this should not happen
mhawryluk
reviewed
May 15, 2022
| * A marker interface for action classes. | ||
| */ | ||
| public interface Action { | ||
| Action VOID = new Action() {}; |
Collaborator
There was a problem hiding this comment.
Should other types of actions be initiated here or is that just for VOID?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist