-
Notifications
You must be signed in to change notification settings - Fork 0
feat: RPG-130 added GUI config loading #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
6c17098
chore: move AnimationTimer to Game class
co012 abdcaf3
chore: bump mockito version
co012 64d27b9
chore: wrapper views
co012 97afc0d
chore: create WrapperController
co012 0a1a220
feat: game is fully wrapped
co012 e3d0c7e
chore: remove onEnd from Game
co012 57255a6
chore: stop animation timer after game end
co012 d42324e
feat: add fastStart
co012 1b0e30a
remove new line
co012 1377d45
chore: fix nullpointer
co012 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| package io.rpg.controller; | ||
|
|
||
| import io.rpg.view.GameEndView; | ||
| import javafx.event.EventType; | ||
| import javafx.scene.input.InputEvent; | ||
| import javafx.scene.input.MouseEvent; | ||
| import javafx.stage.Stage; | ||
|
|
||
| public class GameEndController { | ||
| private final GameEndView view; | ||
| private Runnable onEnd; | ||
|
|
||
| public GameEndController() { | ||
| view = GameEndView.load(); | ||
| onEnd = () -> {}; | ||
| view.setOnClick(this::end); | ||
| } | ||
|
|
||
| public void showGameEnd(Stage stage, String description) { | ||
| view.setDescription(description); | ||
| double prevWidth = stage.getWidth(); | ||
| double prevHeight = stage.getHeight(); | ||
| stage.setScene(view); | ||
| stage.setWidth(prevWidth); | ||
| stage.setHeight(prevHeight); | ||
| } | ||
|
|
||
| public void setOnEnd(Runnable onEnd) { | ||
| this.onEnd = onEnd; | ||
| } | ||
|
|
||
| private void end() { | ||
| onEnd.run(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| package io.rpg.wrapper; | ||
|
|
||
| import java.io.File; | ||
| import java.util.Optional; | ||
| import javafx.stage.FileChooser; | ||
| import javafx.stage.Stage; | ||
|
|
||
| public class ConfigChooser { | ||
| private final FileChooser chooser; | ||
|
|
||
| public ConfigChooser() { | ||
| chooser = new FileChooser(); | ||
| chooser.setTitle("Select root.json"); | ||
| chooser.getExtensionFilters().addAll( | ||
| new FileChooser.ExtensionFilter("config", "root.json"), | ||
| new FileChooser.ExtensionFilter("json", "*.json") | ||
| ); | ||
| } | ||
|
|
||
| /** | ||
| * Open file selection window. | ||
|
|
||
| * @param stage - main stage. | ||
| * @return Optional of selected file folder path. | ||
| */ | ||
| public Optional<String> open(Stage stage) { | ||
| File file = chooser.showOpenDialog(stage); | ||
| if (file == null) { | ||
| return Optional.empty(); | ||
| } | ||
|
|
||
| return Optional.of(file.getParentFile().getAbsolutePath()); | ||
kkafar marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.