Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it clearer in the Initiative Panel if a token is invisible to players #1845

Closed
Merudo opened this issue May 15, 2020 · 9 comments
Closed
Assignees
Labels
feature Adding functionality that adds value tested This issue has been QA tested by someone other than the developer.

Comments

@Merudo
Copy link
Member

Merudo commented May 15, 2020

Is your feature request related to a problem? Please describe.
The Initiative Panel doesn't make it very clear to the GM which of its entries are displayed to players:

  • Tokens on the Hidden layer appear normally
  • NPC tokens with Hide NPCs enabled show up normally
  • Invisible tokens are displayed with a gray label that's a bit darker than normal

Describe the solution you'd like
A clear visual cue for the GM that the tokens are not visible to players.

The Map Explorer displays invisible tokens as semi-transparent to the GM, maybe the same could apply to tokens in the Initiative window.

@Phergus Phergus added the feature Adding functionality that adds value label May 15, 2020
@selquest
Copy link
Contributor

I'm going to try and work on some incremental changes to Initiative this weekend, and this one seems like an easy addition.

@Azhrei
Copy link
Member

Azhrei commented Aug 27, 2020

Given that the existing approach is to color the text the same as it's done on the map, what is your plan for the visual aspects of this change?

@selquest
Copy link
Contributor

Given that the existing approach is to color the text the same as it's done on the map, what is your plan for the visual aspects of this change?

The grey vs blue highlight is definitely a good start, but I figured I'd go with the suggestion of shading the token images (and possibly italicizing the token name) in the same way the Map Explorer does. Should help with the visual distinction, and improve some consistency between the UI panels as a bonus.

@Azhrei
Copy link
Member

Azhrei commented Aug 27, 2020

Ah, that sounds like a good start. I didn't recall that the MapExplorer used italics...

@Phergus Phergus added this to To do in MapTool 1.8.0 via automation Aug 29, 2020
@selquest
Copy link
Contributor

selquest commented Aug 30, 2020

Here's an in-progress example:
MT-1845-InitiativePanelTransparency

The Dragon is not visible to players, and now indicated by italicized text and a transparent token image, in addition to the current dark gray background. I'm waffling a bit on the transparency, since it makes for a kind of weird look with the background. Thoughts?

I think really the heart of the issue is that there's not quite enough contrast between the blue (visible NPC), gray (visible PC), and dark gray (invisible) backgrounds. I'd recommend an alternate color scheme, but ideally we'd actually convert it to an HTML styling that would also be themable. There's a lot more that would have to go into that kind of restructuring though, so it's definitely out of the "incremental improvements" scope.

@Phergus
Copy link
Contributor

Phergus commented Aug 30, 2020

The transparency is a bit weird but that may be me not being used to it. It certainly sticks out that something is different about the token. As I don't use the Initiative panel I don't have a strong opinion one way or the other but I think what you have here works.

Be nice if the PC tokens stood out a bit more but they match the map and map explorer display so that is something for a broader rework.

selquest added a commit to selquest/rptools-maptool that referenced this issue Aug 30, 2020
@selquest
Copy link
Contributor

Committed with the transparency and italic text indicators.

@Phergus Phergus moved this from To do to In progress in MapTool 1.8.0 Aug 31, 2020
@Phergus Phergus moved this from In progress to Review in progress in MapTool 1.8.0 Sep 6, 2020
@Phergus
Copy link
Contributor

Phergus commented Sep 6, 2020

Tested. Tokens not visible to players are partially transparent and use italic text. Working as described.

@Phergus Phergus added documentation needed Missing, out-of-date or bad documentation tested This issue has been QA tested by someone other than the developer. labels Sep 6, 2020
@Phergus Phergus moved this from Review in progress to Reviewer approved in MapTool 1.8.0 Sep 6, 2020
@selquest
Copy link
Contributor

selquest commented Sep 7, 2020

Included discussion of UI indicators in the new http://lmwcs.com/rptools/wiki/Introduction_to_Initiative (still a WIP)

@Phergus Phergus removed the documentation needed Missing, out-of-date or bad documentation label Sep 7, 2020
@Phergus Phergus moved this from Reviewer approved to Done in MapTool 1.8.0 Sep 8, 2020
@Phergus Phergus closed this as completed Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding functionality that adds value tested This issue has been QA tested by someone other than the developer.
Projects
No open projects
MapTool 1.8.0
  
Done
Development

No branches or pull requests

4 participants