New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Description support for MRSS format #1030

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@l1n
Copy link
Contributor

l1n commented Feb 5, 2019

No description provided.

@l1n l1n force-pushed the l1n:master branch from de339cb to f9acdcc Feb 5, 2019

@l1n

This comment has been minimized.

Copy link
Contributor Author

l1n commented Feb 5, 2019

So sorry, hadn't noticed the CI space/tab standard. Ought to be fixed now.

@LogMANOriginal

This comment has been minimized.

Copy link
Member

LogMANOriginal commented Feb 6, 2019

Sorry, #996 just broke this PR.

I'm also not sure if adding the bridge description is useful to the feed. It is meant to be displayed on the front page like this:

image

That being said, maybe support for feed descriptions should be added?

@l1n

This comment has been minimized.

Copy link
Contributor Author

l1n commented Feb 6, 2019

I'll see if I can incorporate this change into the new code soon. The rationale for this is that a bridge could override the getDescription method to have a description based on the underlying (parameterized) data, rather than just a generic one.

@l1n

This comment has been minimized.

Copy link
Contributor Author

l1n commented Feb 6, 2019

Closing this and reopening with a new, functional branch.

@l1n l1n closed this Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment