Skip to content

[ActionFactory] Allow camel-case action names#3044

Merged
dvikan merged 1 commit into
RSS-Bridge:masterfrom
em92:action-camel-case
Sep 20, 2022
Merged

[ActionFactory] Allow camel-case action names#3044
dvikan merged 1 commit into
RSS-Bridge:masterfrom
em92:action-camel-case

Conversation

@em92

@em92 em92 commented Sep 18, 2022

Copy link
Copy Markdown
Contributor

Dash symbol is used to convert dash-seperated string to camel-cased string.

Example: action=set-bridge-cache in query params matches SetBridgeCacheAction

Dash symbol is used to convert dash-seperated string to camel-cased string
@dvikan

dvikan commented Sep 19, 2022

Copy link
Copy Markdown
Contributor

This is a ux feature and yes it kinda looks better but I still prefer to keep the code simpler and dont allow many variations of the action name.

@em92

em92 commented Sep 20, 2022

Copy link
Copy Markdown
Contributor Author

In other my PR (#3043) I meantioned about 2 actions, that currently in my custom branch, but they are planned to pushed here via PR.

One action is called SetBridgeCacheAction (set-bridge-cache), it does what it says.
Other one is called PullJobQueue (pull-job-queue), it return job tasks that should be done by some other worker, for example userscript from the same branch.

Without this PR, they will have unreadable names likes SetbridgecacheAction (setbridgecache) and PulljobqueueAction (pulljobqueue). Other namings like CacheAction and PullAction or JobAction are worse.

@dvikan

dvikan commented Sep 20, 2022

Copy link
Copy Markdown
Contributor

Okay sure. Makes sense.

@dvikan dvikan merged commit 3d9fead into RSS-Bridge:master Sep 20, 2022
@em92 em92 deleted the action-camel-case branch September 20, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants