Skip to content

[ActionFactory] Allow camel-case action names #3044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

em92
Copy link
Contributor

@em92 em92 commented Sep 18, 2022

Dash symbol is used to convert dash-seperated string to camel-cased string.

Example: action=set-bridge-cache in query params matches SetBridgeCacheAction

Dash symbol is used to convert dash-seperated string to camel-cased string
@dvikan
Copy link
Contributor

dvikan commented Sep 19, 2022

This is a ux feature and yes it kinda looks better but I still prefer to keep the code simpler and dont allow many variations of the action name.

@em92
Copy link
Contributor Author

em92 commented Sep 20, 2022

In other my PR (#3043) I meantioned about 2 actions, that currently in my custom branch, but they are planned to pushed here via PR.

One action is called SetBridgeCacheAction (set-bridge-cache), it does what it says.
Other one is called PullJobQueue (pull-job-queue), it return job tasks that should be done by some other worker, for example userscript from the same branch.

Without this PR, they will have unreadable names likes SetbridgecacheAction (setbridgecache) and PulljobqueueAction (pulljobqueue). Other namings like CacheAction and PullAction or JobAction are worse.

@dvikan
Copy link
Contributor

dvikan commented Sep 20, 2022

Okay sure. Makes sense.

@dvikan dvikan merged commit 3d9fead into RSS-Bridge:master Sep 20, 2022
@em92 em92 deleted the action-camel-case branch September 20, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants