New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a sample project for OWIN Middleware #1927

Merged
merged 1 commit into from Feb 7, 2019

Conversation

Projects
None yet
2 participants
@chucklu
Copy link
Contributor

chucklu commented Jan 28, 2019

Hi @RSuter ,
I have made a sample for this tutorial OWIN Middleware
Related issue list:
#1915
#1924
I have modified the tutorial several times for missing dependency. Now I want to provide a sample for it.
If you merge this sample project, then I will add the link on that tutorial.

@RSuter

This comment has been minimized.

Copy link
Owner

RSuter commented Feb 7, 2019

I've seen that you reference NSwag via nuget packages not project references - this is fine. But maybe it's better to move the project into the samples/ directory to keep the solution "small" - or better not make it bigger :-)

@chucklu chucklu force-pushed the ChuckFork:master branch from 90a68c6 to bcac99e Feb 7, 2019

@chucklu

This comment has been minimized.

Copy link
Contributor Author

chucklu commented Feb 7, 2019

Hi @RSuter ,
I have moved the sample project to samples folder.

@RSuter RSuter merged commit b83fb18 into RSuter:master Feb 7, 2019

@RSuter

This comment has been minimized.

Copy link
Owner

RSuter commented Feb 7, 2019

Thanks for the PR!

@chucklu

This comment has been minimized.

Copy link
Contributor Author

chucklu commented Feb 7, 2019

There are lots of sample projects under https://github.com/RSuter/NSwag/tree/master/src
Do you have a plan to move them to the samples folder?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment